New issue
Advanced search Search tips

Issue 767586 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

cros-kernel2.eclass: Drop firmware_install

Project Member Reported by groeck@chromium.org, Sep 21 2017

Issue description

Linux firmware is located in a separate package (linux-firmware) and should be installed from there, not from the Linux kernel. On top of that, starting with version 4.14, the Linux kernel will no longer host firmware files.

 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=v4.14-rc1~11%5e2
firmware: delete in-kernel firmware

The last firmware change for the in-kernel firmware source code was back
in 2013.  Everyone has been relying on the out-of-tree linux-firmware
package for a long long time.

So let's drop it, it's baggage we don't need to keep dragging around
(and having to fix random kbuild issues over time...)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c4798a0abc2972dcf89718c444b13f630e53777e

commit c4798a0abc2972dcf89718c444b13f630e53777e
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue Sep 26 20:36:17 2017

Do not run firmware_install on recent kernel versions

The Linux firmware now resides in the separate linux-firmware package
and should be installed from there. On top of that, starting with
release 4.14 the Linux kernel will no longer host Linux firmware.
Lets drop firmware_install starting with chromeos-4.4.

BUG= chromium:767586 
TEST=Build and test images for all kernel versions

Change-Id: I693c120b429819a816075be4c352866270671671
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/677606
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-9999.ebuild
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-9999.ebuild
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/sys-kernel/chromeos-kernel-3_18/chromeos-kernel-3_18-9999.ebuild
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/eclass/cros-kernel2.eclass
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/sys-kernel/chromeos-kernel-3_14/chromeos-kernel-3_14-9999.ebuild
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/sys-kernel/chromeos-kernel-4_12/chromeos-kernel-4_12-9999.ebuild
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/sys-kernel/chromeos-kernel-3_10/chromeos-kernel-3_10-9999.ebuild
[modify] https://crrev.com/c4798a0abc2972dcf89718c444b13f630e53777e/profiles/targets/chromeos/package.use

Status: Fixed (was: Assigned)
Labels: OS-Chrome
BTW, not a big deal, but this still kinda screws with my normal upstream workflow, where I check out an upstream tree in the kernel directory normal used by the board (e.g., v4.4 with kevin). I now have to remember to do USE="-firmware_install" (and also USE="-clang" for now), or else it won't build.

I guess I'm just whining...or, is it fair to derive the kernel version from the source tree, and stub out firmware_install if it's too new? I see the linux-info eclass already provides helpers for this, and we use them to a limited extent.
Are you sure you still need -firmware_install for 4.4 ? Older kernels, yes, but 4.4 should have it disabled by default.



https://chromium-review.googlesource.com/692617

Even if you were correct, the problem would still occur for anyone testing on 3.18 ebuilds and earlier.
Cc: diand...@chromium.org
I thought that

https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/729700/

reverted CL:692617 and solved the problem. What else is needed ?

> What else is needed ?

For me to sync my tree, I guess ;)

Sorry for the noise.

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment