New issue
Advanced search Search tips

Issue 767584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cleanup back button for vertical shelf calculations.

Project Member Reported by sammiequon@chromium.org, Sep 21 2017

Issue description

Tablet mode will soon force the shelf to be at the bottom. There will be some unused code regarding the tablet mode only back button for vertical shelf. These should be removed from app_list_button.cc and shelf_view.cc.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a87fc3285677f9c3903542925e1fc7f2a1dbacaf

commit a87fc3285677f9c3903542925e1fc7f2a1dbacaf
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Nov 10 17:43:37 2017

shelf: Do not animate to/from tablet mode if alignments are different.

Also remove some code which handles placing the back/launcher button
when the alignment is on the left/right for tablet mode (alignment is
forced bottom for tablet mode now).

Test: manual
Bug:  767584 
Change-Id: If01d403589222e2afb0d048d198fa341a933057e
Reviewed-on: https://chromium-review.googlesource.com/759420
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515588}
[modify] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/ash/shelf/app_list_button.cc
[modify] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/ash/shelf/shelf.h
[modify] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/ash/shelf/shelf_controller.cc
[modify] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/ash/shelf/shelf_view.cc
[modify] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/ash/shelf/shelf_view.h
[modify] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/ash/shelf/shelf_view_unittest.cc

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment