New issue
Advanced search Search tips

Issue 767571 link

Starred by 3 users
Status: Fixed
Owner:
kozy@chromium.org
Closed: Feb 2018
Cc:
vamshi.kommuri@chromium.org
kozy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Breakpoints do not work for workers

Project Member Reported by alph@chromium.org, Sep 21 2017 
1. Open DevTools #1 for a page.
2. Open DevTools #2 for DevTools #1.
3. In DevTools #2 open HeapSnapshot.js and place breakpoint in the beginning of '_buildAggregates' function.
4. Take a heap snapshot in DevTools #1
5. It should stop at the breakpoint but it does not.

Comment 1 by alph@chromium.org, Sep 21 2017 

And yes, as it could be related to workspaces, I do have persistence experiment enabled.

Comment 2 by kozyatinskiy@chromium.org, Oct 16 2017

Owner: kozy@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29e9b753d74f3c045a7b03ce01100d2d0207d3c7

commit 29e9b753d74f3c045a7b03ce01100d2d0207d3c7
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Feb 13 18:19:00 2018

[DevTools] store primary UISourceCode in breakpoint instead of projectId

Breakpoint uses primary UISourceCode to set fake breakpoint location and
to track lifetime of breakpoint in UI.
As long as primary UISourceCode exists, we show all breakpoints related
source decorations, when primary UISourceCode is removed, we remove all
decorations and move breakpoint to temporary storage (provisional
breakpoints). As soon as new UISourceCode with breakpoint url is added
we update breakpoint state and restore decorations.

+ migrated Storage to Map.

R=dgozman@chromium.org

Bug:  chromium:767571 
Change-Id: Ic700d53149e58c912668f954a141f8584713d794
Reviewed-on: https://chromium-review.googlesource.com/915133
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536405}
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dynamic-scripts-breakpoints.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-2.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-3.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-breakpoints.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-1.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/29e9b753d74f3c045a7b03ce01100d2d0207d3c7/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dbbea436cb9d75ede0f40cc790b591ff0ad7371

commit 2dbbea436cb9d75ede0f40cc790b591ff0ad7371
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Feb 14 02:14:45 2018

[DevTools] breakpoint manager with warranty

Every time when we set existing breakpoint in new UISourceCode we just
change primary UISourceCode.
It is crucial to have only one Breakpoint object per storage id since
every breakpoint observes all targets and tries to set itself there.
As soon as we get two breakpoints with the same url, one of them
will get "breakpoint exists" error and will destroy
itself and other breakpoints at the same url.

R=dgozman@chromium.org

Bug:  chromium:767571 
Change-Id: Iaae9659ea9602c48f8aaa5de3a35ad1bf810e33f
Reviewed-on: https://chromium-review.googlesource.com/915421
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536611}
[add] https://crrev.com/2dbbea436cb9d75ede0f40cc790b591ff0ad7371/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers-expected.txt
[add] https://crrev.com/2dbbea436cb9d75ede0f40cc790b591ff0ad7371/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js
[modify] https://crrev.com/2dbbea436cb9d75ede0f40cc790b591ff0ad7371/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint-expected.txt
[add] https://crrev.com/2dbbea436cb9d75ede0f40cc790b591ff0ad7371/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/resources/worker.js
[modify] https://crrev.com/2dbbea436cb9d75ede0f40cc790b591ff0ad7371/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations.js
[modify] https://crrev.com/2dbbea436cb9d75ede0f40cc790b591ff0ad7371/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Comment 5 by kozy@chromium.org, Feb 14 2018

Status: Fixed (was: Assigned)

Comment 6 by kozy@chromium.org, Mar 6 2018

Cc: kozy@chromium.org vamshi.kommuri@chromium.org
 Issue 818505  has been merged into this issue.
►

Sign in to add a comment