Toolbar overlaps the status bar on iPhoneX after rotating portrait/landscape |
|||||||
Issue descriptionApp Version: 63.0.3222.0 iOS Version: iOS11 Device: iPhoneX URL: any URL Steps to reproduce: 1. In a new tab search for a query 2. Once SRP loads, rotate to landscape mode 3. Place cursor in omnibox and then rotate device to portrait mode Observed results: Notice the toolbar is overlapping with the status bar. Expected results: No overlap. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install:Yes Bug reproducible after clearing cache and cookies:Yes Observed behavior in Chrome Mobile on Android: NA Check for similar behavior on Firefox/Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Yes Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): Yes Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_SEM5OUVSS3cyRzQ/view
,
Sep 26 2017
I have a fix for this.
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be4f437a5eb20f3955c0b56a8a7a54aa3999c85b commit be4f437a5eb20f3955c0b56a8a7a54aa3999c85b Author: Jean-François Geyelin <jif@chromium.org> Date: Wed Sep 27 12:44:08 2017 Default the toolbar height to 44 and ignore the safe area in Stack View. Bug: 768868 , 767516 , 767566 Change-Id: I8c2de3f2788bb0af090293ac4ead13b23bb73c78 Reviewed-on: https://chromium-review.googlesource.com/684743 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#504640} [modify] https://crrev.com/be4f437a5eb20f3955c0b56a8a7a54aa3999c85b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm [modify] https://crrev.com/be4f437a5eb20f3955c0b56a8a7a54aa3999c85b/ios/chrome/browser/ui/ui_util.mm
,
Sep 27 2017
,
Sep 27 2017
This bug requires manual review: Less than 16 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 27 2017
will be verified in the next canary
,
Oct 2 2017
Is this verified as working on the iPhone X?
,
Oct 2 2017
The toolbar no longer overlaps the status bar. iPhoneX 63.0.3231.0 Screenshot portrait: https://drive.google.com/file/d/0By4O1f2IQqQ_VTlfc2J0ZVY3Z00/view Landscape is ...noticeably extra padded in the toolbar, but I believe this is a know side effect of the feasible fix for 62. We'd expect this to be fixed in 63. Screenshot landscape: https://drive.google.com/file/d/0By4O1f2IQqQ_aWlBeTdKc2ZGQlU/view Is there a tracker for this (the above extra padding I mentioned), Jif?
,
Oct 2 2017
Thanks Lindsay. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=770693
,
Oct 2 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/716c27c9f37ba80f0f29892ddcf39d04ffd61127 commit 716c27c9f37ba80f0f29892ddcf39d04ffd61127 Author: Jean-François Geyelin <jif@chromium.org> Date: Tue Oct 03 13:40:39 2017 Default the toolbar height to 44 and ignore the safe area in Stack View. Bug: 768868 , 767516 , 767566 Change-Id: I8c2de3f2788bb0af090293ac4ead13b23bb73c78 Reviewed-on: https://chromium-review.googlesource.com/684743 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#504640}(cherry picked from commit be4f437a5eb20f3955c0b56a8a7a54aa3999c85b) Reviewed-on: https://chromium-review.googlesource.com/697725 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#558} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/716c27c9f37ba80f0f29892ddcf39d04ffd61127/ios/chrome/browser/ui/stack_view/stack_view_controller.mm [modify] https://crrev.com/716c27c9f37ba80f0f29892ddcf39d04ffd61127/ios/chrome/browser/ui/ui_util.mm |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mard...@chromium.org
, Sep 26 2017