Bad variable name in login manager |
||
Issue descriptionThis should use 'wallpaper' rather than model https://cs.corp.google.com/chromeos_internal/src/platform2/login_manager/chrome_setup.cc?type=cs&q=f:login+wallpaper+crosconfig&sq=package:%5Echromeos_(internal%7Cpublic)$&l=482
,
Oct 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c4c4b3027670c8bddd1d52ecd603edbb84c03eb4 commit c4c4b3027670c8bddd1d52ecd603edbb84c03eb4 Author: Simon Glass <sjg@chromium.org> Date: Sat Oct 07 22:33:39 2017 login: Correct 'model' variable name The property returned from the config is a filename, not a model. In fact it is quite confusing to call it a model. Update it. BUG= chromium:767562 TEST=FEATURES=test emerge-reef chromeos-login Change-Id: Id4946a51f16f63281318cb3ddb9355c5884814ad Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/705916 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/c4c4b3027670c8bddd1d52ecd603edbb84c03eb4/login_manager/chrome_setup.cc
,
Oct 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sjg@chromium.org
, Oct 6 2017