New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767559 link

Starred by 1 user
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Correctly propagate opacity

Project Member Reported by vollick@chromium.org, Sep 21 2017 
Opacity inheritance is broken at the moment preventing subtrees from being hidden/shown correctly.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95cec00deafc664611f2b563a2970b9a78e54c81

commit 95cec00deafc664611f2b563a2970b9a78e54c81
Author: Ian Vollick <vollick@chromium.org>
Date: Thu Sep 21 20:02:26 2017

[vr] Fix opacity inheritance

This CL fixes a bug in UiElement::UpdateInheritedProperties where we
were accidentally pulling the parent's local, not combined opacity.

Bug:  767559 
Change-Id: Ie8092299ec32229f73e89172b352959e75b7bfd6
Reviewed-on: https://chromium-review.googlesource.com/676664
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503541}
[modify] https://crrev.com/95cec00deafc664611f2b563a2970b9a78e54c81/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/95cec00deafc664611f2b563a2970b9a78e54c81/chrome/browser/vr/ui_scene_manager_unittest.cc

Comment 2 by vollick@chromium.org, Sep 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment