New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767558 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----

Blocking:
issue 769546



Sign in to add a comment

100% confidence at wrong commits after culprits adding the test

Project Member Reported by st...@chromium.org, Sep 21 2017

Issue description

Comment 1 by st...@chromium.org, Sep 21 2017

Labels: -Pri-3 Pri-1
We could go with 1 for now, for 2 we need to figure out a reasonable distance between the two commits.
For 3, it is unclear to me how to improve. Brandon, any thought here?

Comment 2 by st...@chromium.org, Sep 21 2017

Owner: lijeffrey@chromium.org
Status: Assigned (was: Available)
Blocking: 767895

Comment 4 by wylieb@chromium.org, Sep 25 2017

Blocking: -767895

Comment 5 by wylieb@chromium.org, Sep 25 2017

Blocking: 767895
Blocking: 769546
Labels: -Pri-1 Pri-3
After some further investigation into these two tests, the confidence score of 100% is being set due to confidence.SteppinessForCommitPosition indeed identifying them as 100%.

Since there are so few data points, and they are a string of "100%" passing with a sudden dip and no subsequent points after that, this is actually a corner case where steppiness indeed comes back with a 1.0 confidence score.

Seeing as this is indeed the behavior (correctly passing the data points to the steppiness algorithm), this is not a bug, but rather an improvement needed to be made to setting confidence scores.

For now there is no action needed since this technically isn't a bug as the behavior was correct (check if the suspected data point added a new test, which this correctly saw that it was not the commit that added the test and fell back to using confidence.SteppinessForCommitPosition as expected). Rather, this bug should be repurposed to make steppiness smarter.

Removing the metabug for the september 29 release.
Blocking: -767895

Sign in to add a comment