100% confidence at wrong commits after culprits adding the test |
||||||||
Issue descriptionhttps://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubWVtb3J5L01hYyBBU2FuIDY0IFRlc3RzICgxKS8zNDM3My9pbnRlcmFjdGl2ZV91aV90ZXN0cy9RbkpwWkdkbFpFNWhkR2wyWlZkcFpHZGxkRlZKVkdWemRDNUlhWFJVWlhOMAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVypQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJvY2hyb21pdW0ubWFjL01hYzEwLjEyIFRlc3RzLzU1MTMvaW50ZXJhY3RpdmVfdWlfdGVzdHMgb24gTWFjLTEwLjEyL1FuSnBaR2RsWkU1aGRHbDJaVmRwWkdkbGRGVkpWR1Z6ZEM1SWFYUlVaWE4wDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Possible options: 1. Only commit after a test-not-existing data point could be set 100%. 2. For case above, if the commit adding the test is not too far from the commit of the first flaky data point, set it as 100% instead of the flaky data point. 3. Improve FindTruePassRate to set a higher minimum iteration for stable data points
,
Sep 21 2017
,
Sep 22 2017
,
Sep 25 2017
,
Sep 25 2017
,
Sep 27 2017
,
Sep 27 2017
After some further investigation into these two tests, the confidence score of 100% is being set due to confidence.SteppinessForCommitPosition indeed identifying them as 100%. Since there are so few data points, and they are a string of "100%" passing with a sudden dip and no subsequent points after that, this is actually a corner case where steppiness indeed comes back with a 1.0 confidence score. Seeing as this is indeed the behavior (correctly passing the data points to the steppiness algorithm), this is not a bug, but rather an improvement needed to be made to setting confidence scores. For now there is no action needed since this technically isn't a bug as the behavior was correct (check if the suspected data point added a new test, which this correctly saw that it was not the commit that added the test and fell back to using confidence.SteppinessForCommitPosition as expected). Rather, this bug should be repurposed to make steppiness smarter. Removing the metabug for the september 29 release.
,
Sep 27 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by st...@chromium.org
, Sep 21 2017