New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767556 link

Starred by 1 user
Status: Fixed
Owner:
█ zhaobin@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Increase livenessTimeout value for cast channel if it previously errored due to ping_timeout

Project Member Reported by zhaobin@chromium.org, Sep 21 2017 
Created a chromium side bug for tracking. 

Derek suggests that "we dynamically adjust the ping timeout value (known as livenessTimeout) based on past behavior. If a channel previously errored out due to ping_timeout, then the livenessTimeout value is bumped up slightly the next time we re-create the channel. This will help in cases where the ping messages takes a longer time to return by not prematurely closing the channel."

ref: b/37511031

Comment 1 by zhaobin@chromium.org, Sep 22 2017 

UMA metrics for MediaRouter.Cast.Channel.ConnectResult shows that 70% channel open requests on Windows fail. Would like to experiment with different global connect_timeout value first.

Comment 2 by sko...@chromium.org, Sep 25 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e7872934a0d675fcc4ad3b503efcf05ea516fe

commit d1e7872934a0d675fcc4ad3b503efcf05ea516fe
Author: Bin Zhao <zhaobin@chromium.org>
Date: Tue Oct 03 01:38:01 2017

[Media Router] Make connect_timeout value a finch parameter

- Make connect_timeout value configurable via finch, so that we can experiment with different
global connect_timeout value
- Remove kEnableCastChannelRetry feature. It seems useless, and retry parameters can be associated
with kEnableCastDiscovery

Bug:  767556 
Change-Id: I0fb3ef1418e96a25bd37d464f270687ff583b6c0
Reviewed-on: https://chromium-review.googlesource.com/677027
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505912}
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.h
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/chrome/browser/media/router/media_router_feature.h
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/components/cast_channel/cast_socket_service.cc
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/components/cast_channel/cast_socket_service.h
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/components/cast_channel/cast_socket_service_unittest.cc
[modify] https://crrev.com/d1e7872934a0d675fcc4ad3b503efcf05ea516fe/components/cast_channel/cast_test_util.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45b03267e0bc1ba967b9d4bf6b4b73828d07d592

commit 45b03267e0bc1ba967b9d4bf6b4b73828d07d592
Author: Bin Zhao <zhaobin@chromium.org>
Date: Tue Oct 03 20:25:16 2017

[Media Router] Add a dynamic timeout delta finch parameter for in-browser Cast discovery

- Made ping_interval and liveness_interval configurable.
- Added a dynamic timeout delta parameter. If previous open channel operation fails, next open will use
connect_timeout = previous connect_timeout + delta, ping_timeout = previous ping_timeout + delta.

Also did some code clean up:

- Extracted finch parameter related code from CastMediaSinkServiceImpl into CastMediaSinkServiceImplParams
- Cleaned up CastSocketService::OpenSocket()

Bug:  767556 
Change-Id: I77b4f622e41bd355faf01310a637dc374e9a9e83
Reviewed-on: https://chromium-review.googlesource.com/691151
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506155}
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.h
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/components/cast_channel/cast_socket_service.cc
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/components/cast_channel/cast_socket_service.h
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/components/cast_channel/cast_socket_service_unittest.cc
[modify] https://crrev.com/45b03267e0bc1ba967b9d4bf6b4b73828d07d592/components/cast_channel/cast_test_util.h

Comment 5 by zhaobin@chromium.org, Oct 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment