New issue
Advanced search Search tips

Issue 767552 link

Starred by 1 user
Status: Fixed
Owner:
proberge@chromium.org
Closed: Oct 2017
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Stop reporting variations seed signature incidents

Project Member Reported by proberge@chromium.org, Sep 21 2017 
As part of the plan to transfer ownership of incident reporting to the Chrome SafeBrowsing team, we will be removing maintenance-intensive components.

The Variations Seed signature analyzer and associated variations seed signature incidents currently have very little impact as the triggering rate is very low. We should re move it.

Comment 1 by vakh@chromium.org, Sep 29 2017

Labels: SafeBrowsing-Triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806

commit 7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806
Author: proberge <proberge@chromium.org>
Date: Mon Oct 02 17:22:09 2017

Disable and remove the variations seed signature incident

Also removes code in components/variations which was added to support
this incident.

Bug:  767552 
Change-Id: I4530556950673aada12288131549fad5785df09c
Reviewed-on: https://chromium-review.googlesource.com/677564
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505660}
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/chrome/browser/safe_browsing/incident_reporting/incident.h
[delete] https://crrev.com/53eaefaa918f32a4bfbc79f90d2de6bada2a1a16/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc
[delete] https://crrev.com/53eaefaa918f32a4bfbc79f90d2de6bada2a1a16/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h
[delete] https://crrev.com/53eaefaa918f32a4bfbc79f90d2de6bada2a1a16/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.cc
[delete] https://crrev.com/53eaefaa918f32a4bfbc79f90d2de6bada2a1a16/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.h
[delete] https://crrev.com/53eaefaa918f32a4bfbc79f90d2de6bada2a1a16/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_unittest.cc
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/chrome/test/BUILD.gn
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/components/safe_browsing/proto/csd.proto
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/components/variations/service/variations_service.cc
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/components/variations/service/variations_service.h
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/components/variations/variations_seed_store.cc
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/components/variations/variations_seed_store.h
[modify] https://crrev.com/7b46feb03f7cf8dd2f04aa8a4a7ec80d4af00806/components/variations/variations_seed_store_unittest.cc

Comment 3 by proberge@chromium.org, Oct 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment