New issue
Advanced search Search tips

Issue 767547 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 766864
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 557406



Sign in to add a comment

mash: Crash on login restoring V1 app window with shelf model sync.

Project Member Reported by msw@chromium.org, Sep 21 2017

Issue description

mash: Crash on login restoring V1 app window with shelf model sync.

On ChromeOS ToT (or after #502992) with --login-manager:
(1) Pin Chrome Web Store to the shelf (from the app list).
(2) In the item's right-click context menu, select "Open as Window"
(3) Click the item to open a Chrome Web Store window.
(4a) Quit and re-run with --ash-enable-shelf-model-synchronization
(4b) Enable shelf model sync in about:flags and logout/login on device.
Expected: The session starts up just fine.
Actual: Crash attempting to restore the shelf item.

I'll look into why ChromeLauncherController::ShelfItemChanged is called, etc.
This should block enabling shelf model sync by default.

[71292:71292:0921/112934.661879:FATAL:shelf_controller.cc(215)] Check failed: index >= 0 (-1 vs. 0) No item found with the id: app_id:ahfgeienlihckogmohjhadlkjgocpleb, launch_id:
#0 0x7ffac746feec base::debug::StackTrace::StackTrace()
#1 0x7ffac7495a5c logging::LogMessage::~LogMessage()
#2 0x7ffac1f1c68c ash::ShelfController::UpdateShelfItem()
#3 0x7ffac21b2f98 ash::mojom::ShelfControllerStubDispatch::Accept()
#4 0x7ffac669ef1b mojo::InterfaceEndpointClient::HandleValidatedMessage()
#5 0x7ffac669e846 mojo::FilterChain::Accept()
#6 0x7ffac66a0235 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#7 0x7ffac66aa3b4 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#8 0x7ffac66a9904 mojo::internal::MultiplexRouter::Accept()
#9 0x7ffac669e846 mojo::FilterChain::Accept()
#10 0x7ffac6699a45 mojo::Connector::ReadSingleMessage()
#11 0x7ffac669a531 mojo::Connector::ReadAllAvailableMessages()
#12 0x7ffac669a3d9 mojo::Connector::OnHandleReadyInternal()
#13 0x7ffac669ab85 mojo::SimpleWatcher::DiscardReadyState()
#14 0x7ffac6663e74 mojo::SimpleWatcher::OnHandleReady()
#15 0x7ffac66643b1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#16 0x7ffac747077f base::debug::TaskAnnotator::RunTask()
#17 0x7ffac74a00f9 base::internal::IncomingTaskQueue::RunTask()
#18 0x7ffac74a23a3 base::MessageLoop::RunTask()
#19 0x7ffac74a2ace base::MessageLoop::DoWork()
#20 0x7ffac74a5369 base::MessagePumpLibevent::Run()
#21 0x7ffac74a1eb2 base::MessageLoop::Run()
#22 0x7ffac74d617f base::RunLoop::Run()
#23 0x5588700837da ChromeBrowserMainParts::MainMessageLoopRun()
#24 0x7ffac4914567 content::BrowserMainLoop::RunMainMessageLoopParts()
#25 0x7ffac4916f46 content::BrowserMainRunnerImpl::Run()
#26 0x7ffac490fdbf content::BrowserMain()
#27 0x7ffac518864c content::ContentMainRunnerImpl::Run()
#28 0x7ffac79ba09e service_manager::Main()
#29 0x7ffac5187024 content::ContentMain()
#30 0x55886f6641c8 ChromeMain
#31 0x7ffabb532f45 __libc_start_main
#32 0x55886f664004 <unknown>

 

Comment 1 by msw@chromium.org, Sep 21 2017

Mergedinto: 766864
Status: Duplicate (was: Assigned)
This seems like a dup of  Issue 766864 ; great! That needed a repro!
ChromeLauncherController::Init has a third ShelfModel item for the Web Store:

[79823:79823:0921/115510.810606:ERROR:chrome_launcher_controller.cc(289)] Expected two shelf items, actual: 3
[79823:79823:0921/115510.810613:ERROR:chrome_launcher_controller.cc(291)] Shelf Item: Launcher (app_id:jlfapfmkapbjlfbpjedlinehodkccjee, launch_id:)
[79823:79823:0921/115510.810621:ERROR:chrome_launcher_controller.cc(291)] Shelf Item:  (app_id:mgndgikekgjfcpckkfioiadnlibdjbkf, launch_id:)
[79823:79823:0921/115510.810627:ERROR:chrome_launcher_controller.cc(291)] Shelf Item: Web Store (app_id:ahfgeienlihckogmohjhadlkjgocpleb, launch_id:)
[79823:79823:0921/115510.810637:FATAL:chrome_launcher_controller.cc(292)] Check failed: false. Please report the above errors to  http://crbug.com/766864 
#0 0x7fd8bd4e2eec base::debug::StackTrace::StackTrace()
#1 0x7fd8bd508a5c logging::LogMessage::~LogMessage()
#2 0x55c6e5d31cd1 ChromeLauncherController::Init()
#3 0x55c6e4609d58 chromeos::internal::ChromeLauncherControllerInitializer::OnSessionStateChanged()
#4 0x7fd8b7af1c30 session_manager::SessionManager::SetSessionState()
#5 0x55c6e46f9ec4 chromeos::ChromeSessionManager::SessionStarted()
#6 0x7fd8bd4e377f base::debug::TaskAnnotator::RunTask()
#7 0x7fd8bd5130f9 base::internal::IncomingTaskQueue::RunTask()
#8 0x7fd8bd5153a3 base::MessageLoop::RunTask()
#9 0x7fd8bd515ace base::MessageLoop::DoWork()
#10 0x7fd8bd518369 base::MessagePumpLibevent::Run()
#11 0x7fd8bd514eb2 base::MessageLoop::Run()
#12 0x7fd8bd54917f base::RunLoop::Run()
#13 0x55c6e4a1c7da ChromeBrowserMainParts::MainMessageLoopRun()
#14 0x7fd8ba987567 content::BrowserMainLoop::RunMainMessageLoopParts()
#15 0x7fd8ba989f46 content::BrowserMainRunnerImpl::Run()
#16 0x7fd8ba982dbf content::BrowserMain()
#17 0x7fd8bb1fb64c content::ContentMainRunnerImpl::Run()
#18 0x7fd8bda2d09e service_manager::Main()
#19 0x7fd8bb1fa024 content::ContentMain()
#20 0x55c6e3ffd1c8 ChromeMain
#21 0x7fd8b15a5f45 __libc_start_main
#22 0x55c6e3ffd004 <unknown>

Sign in to add a comment