New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767535 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Audit alert has multiple entries for the same rule.

Project Member Reported by robert...@chromium.org, Sep 21 2017

Issue description

Look at bug 767325 for example, what happened is that the first time the audit ran, it failed, but it saved a partial result that the second run only appended to.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/62a1cd3454dae85cb3b7bd1c4c0a5a9491202c3d

commit 62a1cd3454dae85cb3b7bd1c4c0a5a9491202c3d
Author: Roberto Carrillo <robertocn@google.com>
Date: Thu Sep 21 20:08:43 2017

[cr-audit-commits] Discard partial results on panic.

If a rule panics while auditing a commit, do not save the results of the
previous rules so that a rerun doesn't append repeated entries to this
incomplete list.

R=stgao,chanli
BUG= 767535 

Change-Id: Ic93117e622c9b48b96ad0aff32c3ec4860c92557
Reviewed-on: https://chromium-review.googlesource.com/677572
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/62a1cd3454dae85cb3b7bd1c4c0a5a9491202c3d/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go

Status: Fixed (was: Started)

Sign in to add a comment