New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767523 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
(currently inactive on Chromium)
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Splash screen doesn't show when coming from Daydream

Project Member Reported by ymalik@chromium.org, Sep 21 2017

Issue description

This is a regression caused by UI rendering rework.
 

Comment 1 by ymalik@chromium.org, Sep 21 2017

Patch that caused this: https://chromium-review.googlesource.com/c/chromium/src/+/675788

Fix is in progress.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5890b651419a4f51a89a474ff6409146ce44d207

commit 5890b651419a4f51a89a474ff6409146ce44d207
Author: Yash Malik <ymalik@google.com>
Date: Thu Sep 21 22:19:07 2017

[vr] Fix splash screen shown for auto-present intents

This regressed in https://chromium-review.googlesource.com/675788.

The problem is that the splash screen was a part of the WebVR subtree and we
weren't drawing the WebVR subtree until the site submitted a frame.

This CL moves the splash screen to its own subtree under kRoot and renders it
regardless of being in WebVR mode.

Bug:  767523 
Change-Id: Ib4f7fcef615e479db89ce2c5fb72e894270aa614
Reviewed-on: https://chromium-review.googlesource.com/677225
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503581}
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/ui_renderer.h
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/5890b651419a4f51a89a474ff6409146ce44d207/chrome/browser/vr/ui_scene_manager.h

Comment 3 by ymalik@chromium.org, Sep 22 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment