New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767516 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Gray bar seen after search and switching to/from potrait and landscape mode in iPhoneX

Project Member Reported by linds...@chromium.org, Sep 21 2017

Issue description


App Version: 63.0.3222.0
iOS Version: iOS11
Device: iPhoneX
URL: SRP

Steps to reproduce:
  1. In landscape, navigate to a page, scroll all the way to the top
  2. Switch to portrait

Observed results:
Observe the gray bar under the toolbar and at the top of the content space

Expected results:
No gray bar should exist.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install:Yes
Bug reproducible after clearing cache and cookies:Yes
Observed behavior in Chrome Mobile on Android: n/a
Check for similar behavior on Firefox/Safari: No
Bug reproducible on current stable build (App Version, iOS Version): Yes
Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): Yes

Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_NDVYNjFBRVVVZk0/view
 

Comment 1 by jif@chromium.org, Sep 26 2017

I also have a fix for this.

Comment 2 by cma...@chromium.org, Sep 27 2017

Great!
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be4f437a5eb20f3955c0b56a8a7a54aa3999c85b

commit be4f437a5eb20f3955c0b56a8a7a54aa3999c85b
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Sep 27 12:44:08 2017

Default the toolbar height to 44 and ignore the safe area in Stack View.

Bug:  768868 ,  767516 ,  767566 
Change-Id: I8c2de3f2788bb0af090293ac4ead13b23bb73c78
Reviewed-on: https://chromium-review.googlesource.com/684743
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504640}
[modify] https://crrev.com/be4f437a5eb20f3955c0b56a8a7a54aa3999c85b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/be4f437a5eb20f3955c0b56a8a7a54aa3999c85b/ios/chrome/browser/ui/ui_util.mm

Comment 4 by jif@chromium.org, Sep 28 2017

Labels: Merge-Request-62
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 28 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Less than 15 days to go before AppStore submit on M62
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by jif@chromium.org, Sep 28 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on ToT (63.0.3231.0) iPhoneX Simulator.
Google Search results page is displayed correctly after rotating the device.
Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716c27c9f37ba80f0f29892ddcf39d04ffd61127

commit 716c27c9f37ba80f0f29892ddcf39d04ffd61127
Author: Jean-François Geyelin <jif@chromium.org>
Date: Tue Oct 03 13:40:39 2017

Default the toolbar height to 44 and ignore the safe area in Stack View.

Bug:  768868 ,  767516 ,  767566 
Change-Id: I8c2de3f2788bb0af090293ac4ead13b23bb73c78
Reviewed-on: https://chromium-review.googlesource.com/684743
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504640}(cherry picked from commit be4f437a5eb20f3955c0b56a8a7a54aa3999c85b)
Reviewed-on: https://chromium-review.googlesource.com/697725
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#558}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/716c27c9f37ba80f0f29892ddcf39d04ffd61127/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/716c27c9f37ba80f0f29892ddcf39d04ffd61127/ios/chrome/browser/ui/ui_util.mm

Sign in to add a comment