New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767512 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Confirm all failed step/test are still failing before revert or send notification

Project Member Reported by chanli@chromium.org, Sep 21 2017

Issue description

Currently before revert or send notification, we only check at build level if the build is still red. But we may need to drill down to step/test level.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/edaed07fae14eccae06a9d084df959dd8aead526

commit edaed07fae14eccae06a9d084df959dd8aead526
Author: Chan <chanli@chromium.org>
Date: Fri Aug 24 19:57:54 2018

[Findit] Skip taking actions on a culprit of a compile failure if compile failure stops in any later build.

This CL also includes some preparation for skipping actions on culprits of test failures if any failed step passed in following builds.

Bug:  767512 
Change-Id: I7e5e93ef33da09b4e3a5c21a22abc3d256833c3a
Reviewed-on: https://chromium-review.googlesource.com/1154430
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/test_failure/test/test_culprit_action_test.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/compile_failure/test/compile_culprit_action_test.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/edaed07fae14eccae06a9d084df959dd8aead526/appengine/findit/services/compile_failure/compile_culprit_action.py

There are 3 CLs to add this feature:
- Add shared functions for checking failures that are passed in future builds at step level and use those functions to check compile analyses;
- check failures that are passed in future builds at step level for test analyses;
- check failures that are passed in future builds at test level for test analyses
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/31d8fc5a131ae05f0ff0813730b078416d129291

commit 31d8fc5a131ae05f0ff0813730b078416d129291
Author: Chan <chanli@chromium.org>
Date: Sat Aug 25 03:33:51 2018

[Findit] Skip taking actions on a culprit of a consistent test failure if the same step(s) stops to fail in any later build.

Bug:767512
Change-Id: Iabe3782df6fb8e406768650582a097183f57c964
Reviewed-on: https://chromium-review.googlesource.com/1155796
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/test_failure/test_culprit_action.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/compile_failure/test/identify_compile_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/test_failure/identify_test_try_job_culprit_pipeline.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/parameters.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/test_failure/test/test_culprit_action_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/test/parameters_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/compile_failure/identify_compile_try_job_culprit_pipeline.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/pipelines/test_failure/test/identify_test_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/31d8fc5a131ae05f0ff0813730b078416d129291/appengine/findit/services/test_failure/test_try_job.py

Status: Fixed (was: Assigned)

Sign in to add a comment