New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767507 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 767486



Sign in to add a comment

Make --expose-internals-for-testing work in Android content tests

Project Member Reported by rlanday@chromium.org, Sep 21 2017

Issue description

Currently, there's no way to read or modify DocumentMarkers in an Android content test. This means that e.g. tests that test spell check features need to actually rely on spell check itself to add spell check markers, which results in flakiness:
https://bugs.chromium.org/p/chromium/issues/detail?id=767486

and also, there's no way to test that DocumentMarkers that only result in painting with no other effects (e.g. composition markers) are added properly:
https://chromium-review.googlesource.com/c/chromium/src/+/675743#message-fe42b29ea9370f2314e91ecd496cf45688a7076c

Currently, some layout tests use --expose-internals-for-testing to expose a JavaScript API for manipulating DocumentMarkers. If we can make this work in content tests, we can use the API there to improve our test reliability and coverage.
 
Blocking: 767486
Status: WontFix (was: Assigned)
This actually already works if you add

@CommandLineFlags.Add({"expose-internals-for-testing"})

before the test class. Not sure if this is new with the ContentJUnit4ClassRunner tests or if I just was doing something wrong when I tried before.

Sign in to add a comment