New issue
Advanced search Search tips

Issue 767445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Synced address from Wallet creates "duplicate" addresses on iOS

Project Member Reported by se...@chromium.org, Sep 21 2017

Issue description

They are not complete duplicate as the email are different.

In Moe's setup with an iphone and a mac he ends up with and email with with dots removed and one where they are kept.

I don't have this issue with my Linux + Android setup, both keep the dot.
 

Comment 1 by se...@chromium.org, Sep 21 2017

Investigated with Moe. It seems like the iOS code canonicalizes the email here:

https://cs.chromium.org/chromium/src/ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm?l=28

Comment 2 by ma...@chromium.org, Sep 21 2017

Wow good find. Can we fix retroactively?

Comment 3 by se...@chromium.org, Sep 22 2017

Talking with identity team and it seems this canonicalization might not be needed anymore.

Another thing to consider is whether to disregard "." and other stuff when comparing @gmail email addresses.

Comment 4 by se...@chromium.org, Dec 1 2017

Labels: OS-iOS
Summary: Synced address from Wallet creates "duplicate" addresses on iOS (was: Synced address from Wallet creates "duplicate" addresses.)
Cc: -mahmadi@chromium.org se...@chromium.org
Components: UI>Browser>Autofill
Owner: mahmadi@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da79010c3d67fe39905152902f045ff5d3788ae5

commit da79010c3d67fe39905152902f045ff5d3788ae5
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Mon Dec 04 16:06:56 2017

[AF] Don't sanitize or canonicalize email when getting AccountInfo in iOS

currently foo.bar@example.com gets converted to foobar@example.com
which gets saved as part of a server card' billing address. This is
different from the behavior in other platforms which results
in a nearly duplicate autofill profile getting synced across platforms.

Bug:  767445 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I23947f3ae1c7d35ada590e4165f5c2f52744b652
Reviewed-on: https://chromium-review.googlesource.com/804056
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521351}
[modify] https://crrev.com/da79010c3d67fe39905152902f045ff5d3788ae5/ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm

Status: Fixed (was: Started)

Sign in to add a comment