New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767413 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Improve building the firmware updater with cros_workon

Project Member Reported by sjg@chromium.org, Sep 21 2017

Issue description

At present we have the following in ebuilds showing how to uprev the firmware:

# To change firmware versions, update:
#
#   chromeos-base/chromeos-config-bsp/files/model.dtsi
#
# and then paste the function below into your chroot shell and type:
#
#   update_firmware
#
# If this works then you can create a CL with your changes.
#
update_firmware() {
	BOARD="coral"
	cros_workon --board="${BOARD}" start chromeos-config-bsp \
		"chromeos-firmware-${BOARD}"
	base="${HOME}/trunk/src/private-overlays/overlay-${BOARD}-private/chromeos-base"
	ebuild="${base}/chromeos-firmware-${BOARD}/chromeos-firmware-${BOARD}-9999.ebuild"
	touch "${ebuild}"
	"ebuild-${BOARD}" "${ebuild}" manifest
	"emerge-${BOARD}" -q chromeos-config-bsp chromeos-config \
		"chromeos-firmware-${BOARD}"
}

It would be good to put this in a script. Perhaps we can also make changes to portage so that the 'touch' is not necessary?

 

Comment 1 by sjg@chromium.org, Oct 18 2017

Labels: -Pri-3 Pri-1
Status: Started (was: Untriaged)
A CL is up for this:

https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/726845

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/85217e1e62f3f092302349f31b5e08559b28a6e3

commit 85217e1e62f3f092302349f31b5e08559b28a6e3
Author: Simon Glass <sjg@chromium.org>
Date: Tue Oct 31 22:15:20 2017

Add a script to update firmware after a config change

This is a common requirement and currently people have to paste a shell
function into their terminal. Add a script for this instead.

BUG= chromium:767413 
TEST=./cros_update_firmware -b coral

Change-Id: Ice0654e37e54998357cb97d67c268775525964d6
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/726845
Reviewed-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/85217e1e62f3f092302349f31b5e08559b28a6e3/cros_update_firmware

Comment 3 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild

Comment 4 by sjg@chromium.org, Nov 28 2017

Next step here is to update the cros_workon packages so that it automatically auto-revs and we don't need a manual change in the firmware ebuild.

Comment 5 by sjg@chromium.org, Apr 25 2018

Status: Fixed (was: Started)
Well we ended up just continuing to use the script. I think it is unnecessary and annoying, but will leave it as it is for now. Maybe later in the Grunt project I will take another crack.

Sign in to add a comment