New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767408 link

Starred by 2 users
Status: Duplicate
Merged: issue 344941
Owner:
e...@chromium.org
Closed: Oct 2017
Cc:
█ msten...@opera.com
█ cathiec...@tencent.com
battun@chromium.org
aluo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Unwanted space between suggestion is seen in the mentioned link

Reported by ngo...@etouch.net, Sep 21 2017 
Device name: Pixel XL 8.0.0/(OPR3.170623.007), Nexus 5X/(N2G47O), Samsung Galaxy J2/(LMY47X), Micromax Q372/5.1 (LRX21M), Sony Xperia XA/6.0(33.2.B.2.93), ASUS_Z010D /6.0.1(MMB29P), Htc Desire 630/6.0.1(1.00.400.3), Panasonic Eluga Turbo/5.1(LMY4&D), Gionee F103/5.0 (LRX21M), Samsung Galaxy J2 5.1.1/(LMY47X)
WebView version: 63.0.3220.0
Application: Webview Shell Browser
Application version: 1.0

Test URL: https://giphy.com

Bisect Information: This is a regression issue broken in 'M-59'

Per-Version bisect information:
Good build: 59.0.3050.0
Bad build: 59.0.3051.3

Regression range: https://chromium.googlesource.com/chromium/src/+log/59.0.3050.0..59.0.3051.3?pretty=fuller&n=10000

Steps to reproduce:
1. Navigate to the above mentioned link > Tap into the search bar.
3. Observe the suggestions.


Expected result: Suggestion should be seen without any gaps.

Actual result: Suggestion appear with unwanted gaps.


Additional note: Issue is reproducible on Chrome Dev (63.0.3220.0)

Comment 1 by battun@chromium.org, Sep 22 2017

Labels: -Pri-3 M-63 Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Please find the log and Video @ http://go/chrome-androidlogs1/7/767408

Comment 2 by battun@chromium.org, Sep 22 2017

Labels: ReleaseBlock-Stable
Owner: atotic@chromium.org
Status: Assigned (was: Untriaged)
Per-CL bisect information:
Good commit:459371
Bad commit:459372

Suspect CL:
https://chromium.googlesource.com/chromium/src/+/fd1e60f0bee4b6b25d898f4f4f859aa38d1a9643

atotic@  Might be it looks like this issue is related to your change. please look into once, if its not related to your change please reassign to me. 
Thanks!

Comment 3 by battun@chromium.org, Sep 22 2017

Components: -Mobile>WebView

Comment 4 by atotic@chromium.org, Sep 22 2017

Owner: battun@chromium.org
I've looked at the change you've pointed to:

https://chromium.googlesource.com/chromium/src/+/fd1e60f0bee4b6b25d898f4f4f859aa38d1a9643

and I was not the author or reviewer. I do remember looking at that patch. How did you connect me to this CL?

Comment 5 by battun@chromium.org, Sep 25 2017

Labels: hasbisect-per-revision
Owner: satyavat...@chromium.org
Satya@ i have tried per-cl bisect on signed device using chromium then showing above CL #2 but when we tried on AOSP using chromium or webview shell browser showing other CL. Could you please assign to respective owner.

Per-CL bisect information:
Good commit:459356
Bad commit:459378

Suspect CL:
https://chromium.googlesource.com/chromium/src/+/0b9612c36b6ba03e3f007114bff6347295c7d427

Thanks!

Comment 6 by battun@chromium.org, Sep 28 2017

Cc: satyavat...@chromium.org
Owner: gambard@chromium.org
gambard@  Might be it looks like this issue is related to your change. please look into once, if its not related to your change please reassign back to me. 
Thanks!

Comment 7 by gambard@chromium.org, Sep 28 2017

Owner: battun@chromium.org
My change is iOS only. Unless I misread the bug description, it looks like this is an Android only bug.
Reassigning back.

Comment 8 by satyavat...@chromium.org, Sep 28 2017 

battun@,
cl in #5 only for IOS, see crbug/704082 (please look at associated bug in the cl/commits that helps) 

It is strange that is pointing to different cl's in #2 and #5.  

Could you mind checking on latest M63 build, if it repro's (I think it would)then try to bisect?

Thanks!

Comment 9 by satyavat...@chromium.org, Sep 29 2017

Cc: -satyavat...@chromium.org
Owner: satyavat...@chromium.org

Comment 10 by satyavat...@chromium.org, Oct 2 2017

Owner: aluo@chromium.org
aluo@,

battun@ tried to bisect after #8 comment too, but it seems he got the same range.
Could you check why bisect tool giving different commits?

Thanks!

Comment 11 by aluo@chromium.org, Oct 2 2017

Cc: msten...@opera.com cathiec...@tencent.com
Labels: -Restrict-View-Google
Owner: e...@chromium.org
Assigning to reviewer of https://codereview.chromium.org/2759883002 and cc'ing other reviewers and owner as well.  The bug bisected to this change.  This is marked as a release-blocker for M-63 stable and must be fixed asap.  Please see steps in description to reproduce.

Comment 12 by e...@chromium.org, Oct 2 2017

Cc: e...@chromium.org
Labels: -ReleaseBlock-Stable Needs-Bisect Needs-TestConfirmation
Owner: aluo@chromium.org
A bug that has been around since M59 can not possibly be a release blocker for M63.

We also have three *conflicting* regression ranges.

Can we please re-run the regression analysis?

Comment 13 by aluo@chromium.org, Oct 3 2017

Cc: -e...@chromium.org aluo@chromium.org battun@chromium.org
Owner: e...@chromium.org
That's correct, this shouldn't have been marked a blocker, apologies that I had missed this regressed in M-59 and thanks for taking off the blocker label.

The differences in bisect ranges was due to 2 different bisect runs on different architectures.  The 64 bit bisect ran into an issue where some builds weren't available, therefore the resulting range is more that 1 cl.  The 32 bit bisect found all builds so it was narrowed down to the exact cl.  Notice that wider cl range from #5 contains the cl found in #2.  Assigning back to you.

Comment 14 by aluo@chromium.org, Oct 3 2017

Labels: -Needs-TestConfirmation -Needs-Bisect

Comment 15 by e...@chromium.org, Oct 3 2017 

Thanks aluo.

Comment 16 by cathiec...@tencent.com, Oct 8 2017 

Sorry for the delay.

The suggestions in this page is like:

<li>
  <a style="overflow:hidden">ice cream</a>
</li>

After this change https://codereview.chromium.org/2759883002, there will be an empty line above "overflow:hidden" element. I'm still working on it.

I think this issue could merge to  Issue 344941 .

Comment 17 by dtapu...@chromium.org, Oct 27 2017

Components: Blink>Layout

Comment 18 by e...@chromium.org, Oct 31 2017

Mergedinto: 344941
Status: Duplicate (was: Assigned)
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5099b7b47d627181b682a832d0e80f775d20eae

commit f5099b7b47d627181b682a832d0e80f775d20eae
Author: cathiechen <cathiechen@tencent.com>
Date: Thu Nov 02 20:35:35 2017

Fix unnecessary line-break between marker and overflow element.

In order to show marker in list with overflow children, we make marker as
the child of list. This change will generate line-break between marker
and overflow children. To eliminame this line-break:
1. When construct layout tree add marker as child of li which would
generate line-break.
2. To eliminame line-break, set marker_container's logicalHeight to
0px.
3. Align marker's block direction position according to first-line-box
after li's children layouted.

Design document:
https://docs.google.com/document/d/1bMerTLCSqHZYAERJ2HDr-4auOSw0eIx8QfD2vY92TNo

Bug:  775880 ,  767408 ,  344941 
Change-Id: I323be3fdd9447c5487963cb039c7bcc83922dcb8
Reviewed-on: https://chromium-review.googlesource.com/735303
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513595}
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/add-inline-child-after-marker-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/add-inline-child-after-marker.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/li-with-overflow-hidden-change-list-style-position-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/li-with-overflow-hidden-change-list-style-position.html
[modify] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/list-marker-inside-overflow-hidden-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/list-marker-with-lineheight-and-overflow-hidden-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/list-marker-with-lineheight-and-overflow-hidden.html
[modify] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/Source/core/layout/LayoutListItem.h

Comment 20 by cathiec...@tencent.com, Nov 3 2017 

Besides li + overflow issue, this page have another one(li + flex). e.g.:

<li><a style="display:flex;">text</a></li>

Trying to figure this out.
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be

commit e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be
Author: cathiechen <cathiechen@tencent.com>
Date: Tue Nov 14 10:31:33 2017

Eliminate line-breaks generated by list marker.

Apply the design which align the vertical position of marker
according to content to lists with first child like:
1. Writing-mode root
2. LayoutBlock which isn't LayoutBlockflow, such as: flex\table\grid
3. Also fixed overflow with block children.

Bug:  767408 
Change-Id: I0a3550f146a396b86f7d1db77fc0707f179fee26
Reviewed-on: https://chromium-review.googlesource.com/754768
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#516253}
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-block-textarea-expected.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-block-textarea.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-flex-expected.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-flex.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-grid-expected.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-grid.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-writing-mode-expected.html
[add] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-and-writing-mode.html
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/fast/lists/list-marker-before-content-table-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/table-row-group-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/table-row-group-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/table-row-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/table-row-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/table-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/table-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/forms/form-hides-table-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/forms/form-hides-table-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/linux/fast/lists/ordered-list-with-no-ol-tag-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/forms/form-hides-table-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/forms/form-hides-table-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/css-generated-content/table-row-group-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/css-generated-content/table-row-group-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/css-generated-content/table-row-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/css-generated-content/table-row-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/css-generated-content/table-with-before-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/css-generated-content/table-with-before-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/forms/form-hides-table-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/forms/form-hides-table-expected.txt
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/LayoutTests/platform/win/fast/lists/ordered-list-with-no-ol-tag-expected.png
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] https://crrev.com/e4731967b7d936d8b7d5f2d73ae98faa0c1ca9be/third_party/WebKit/Source/core/layout/LayoutListItem.h
►

Sign in to add a comment