Issue metadata
Sign in to add a comment
|
Regression:Black patch appear after clicking on reload button.
Reported by
vku...@etouch.net,
Sep 21 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:63.0.3221.0 Revision e34bc3ba4a14b65c94f4b0ae103473934e32cfdb-refs/heads/master@{#503308}(32/64 Bit) OS:Windows (7,8,8.1,10),Linux (14.04 LTS) What steps will reproduce the problem? (1)Launch chrome and open NTP kill the page manually via chrome://kill (2)Now reload the page and observe Actual: Black patch appear after clicking on reload button. Expected: Black patch should not be seen after clicking on reload button. This is a regression issue broken in 'M63' and below is the manual regression range Good Build: 63.0.3216.0 Bad Build: 63.0.3217.0
,
Sep 21 2017
Not related to the NTP, the same happens on google.com.
,
Sep 21 2017
Adding RB Label as this is recent Regression. Please remove if not required. Thank You.
,
Sep 21 2017
nasko@ - can you help with triage please? (reassigning since clamy@ is OOO) This does indeed seem related to PlzNavigate - I can repro at ~ToT (r502380) (and so with PlzNavigate on by default / after r502251), but I cannot repro with --disable-browser-side-navigation switch.
,
Sep 21 2017
<+kenrb@ and lfg@ who might have experience with similar issues that surfaced during the Site Isolation work>
,
Sep 21 2017
I am not sure why this bug is marked as ReleaseBlock-Stable: - IMO the fact that this is a recent regression (raised in #c3) doesn't seem (on its own) sufficient to declare this a blocker - The only repro steps known today involve a renderer kill/crash. I think this means the bug reproes rarely in practice. - AFAICT the impact of the bug is purely aesthetic / non-functional (and it the impact lasts for ~1 second) Please note that PlzNavigate is currently enabled at 100% for the stable channel.
,
Sep 22 2017
I agree, this doesn't seem severe enough to be a release blocker, as noted in comment 6. lukasza@: Does it repro on M61 or M62 with PlzNavigate enabled? Or is it actually a regression in M63? If it's the latter, maybe we can bisect to find what changed (i.e., run the bisect with PlzNavigate enabled).
,
Sep 22 2017
This doesn't seem to be a recent regression for PlzNavigate - I can also repro the symptoms in 61.0.3163.100 (Linux, 64-bit) when launching it with --enable-browser-side-navigation flag.
,
Oct 6 2017
,
Oct 16 2017
I'm reassigning this to clamy@, as I won't be able to work on this in the near future.
,
Oct 18 2017
Kicked off investigations by introducing a WebContentsObserver and logging a number of potentially useful events (frame/navigation/some document stuff). https://ahemery.users.x20web.corp.google.com/general_plznav_bugs/black_flashing_screen_after_crash_reload/web_content_observer_logs_and_timing
,
Oct 19 2017
It looks like it might be a problem in the cc SetDeferCommits. Without plz nav it is triggered from content::RenderFrameHostManager::Navigate. With plz nav it is triggered (too late ?) from content::RenderFrameHostManager::DidNavigateFrame.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b320a1bb07a05c28d56a0b80e307d3dfdc169ca9 commit b320a1bb07a05c28d56a0b80e307d3dfdc169ca9 Author: Arthur Hemery <ahemery@chromium.org> Date: Fri Oct 20 13:53:26 2017 PlzNav: Moved visibility update in renderFrameManager. The call that triggered the widget to be displayed in a reload was placed in RenderFrameHostManager::CommitPendingIfNecessary which was not reached in all cases (after a crash for example). Moved it to RenderFrameHostManager::GetFrameHostForNavigation which is always called. Bug: 767394 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ifbbc54af972c6b7d36d28420b35f3743f1d6e568 Reviewed-on: https://chromium-review.googlesource.com/730009 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#510423} [modify] https://crrev.com/b320a1bb07a05c28d56a0b80e307d3dfdc169ca9/content/browser/frame_host/render_frame_host_manager.cc
,
Oct 20 2017
,
Oct 23 2017
Retested above issue on Windows(7,8,10) & Linux(14.04 LTS) OS using latest canary #64.0.3247.0 build and issue seems fixed hence adding TE-Verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Sep 21 2017Owner: clamy@chromium.org
Status: Assigned (was: Unconfirmed)
356 KB
356 KB View Download