New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767374 link

Starred by 1 user
Status: Fixed
Owner:
khmel@chromium.org
Closed: Sep 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary navigation to details page is seen on clicking learn more link in chrome://settings/androidApps.

Project Member Reported by jbanavatu@chromium.org, Sep 21 2017 
Chrome Version: 61.0.3163.101/9765.70.0 Beta-Channel  Quawks and Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign in to chrome >> Navigate to chrome://settings/androidApps page
(2)Click on Learn more link and Observe chrome://settings page

Expected:No such unnecessary navigation to chrome://settings/andriodApps/details page should be seen on clicking learn more link in Google playstore(beta) section.
Actual: Instead,Unnecessary navigation to details page is seen.

Note: 
1.Issue is on ARC devices.
2.Issue is also seen on latest M63.

This is regression issue as same is working fine in 57.0.2987.154/9202.71.0 stable channel minnie.

Attaching screen-cast for reference.
Actual.webm
885 KB View Download

Comment 1 by steve...@chromium.org, Sep 21 2017

Cc: steve...@chromium.org
Owner: khmel@chromium.org
I've run into this before but I can't recall where/how (maybe in a previous iteration of this?). An easy solution is to check event.target.type and exit if it is n anchor.

I also happened to notice that androidAppsLearnMore no longer appears to be used in the code.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15938b08ef12483c1ea6fd33800c469d3a25b3a3

commit 15938b08ef12483c1ea6fd33800c469d3a25b3a3
Author: khmel <khmel@google.com>
Date: Thu Sep 21 21:51:50 2017

arc: Prevent navigation to ARC subpage on 'Learn more' link.

Bug:  767374 
Test: Manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f8ba3901dfcbd3f9728551cc375bda182a60eba
Reviewed-on: https://chromium-review.googlesource.com/677410
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503574}
[modify] https://crrev.com/15938b08ef12483c1ea6fd33800c469d3a25b3a3/chrome/app/settings_strings.grdp
[modify] https://crrev.com/15938b08ef12483c1ea6fd33800c469d3a25b3a3/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/15938b08ef12483c1ea6fd33800c469d3a25b3a3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 3 by khmel@chromium.org, Sep 22 2017

Labels: -M-63 Merge-Request-62 M-62
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 22 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 24 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by bhthompson@google.com, Sep 25 2017

Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f21d5af36aee7b988ab11794720d269f1f20de9

commit 5f21d5af36aee7b988ab11794720d269f1f20de9
Author: khmel <khmel@google.com>
Date: Mon Sep 25 20:36:38 2017

[Merge M62] arc: Prevent navigation to ARC subpage on 'Learn more' link.

TBR=khmel@google.com

(cherry picked from commit 15938b08ef12483c1ea6fd33800c469d3a25b3a3)

Bug:  767374 
Test: Manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f8ba3901dfcbd3f9728551cc375bda182a60eba
Reviewed-on: https://chromium-review.googlesource.com/677410
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503574}
Reviewed-on: https://chromium-review.googlesource.com/682877
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#437}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/5f21d5af36aee7b988ab11794720d269f1f20de9/chrome/app/settings_strings.grdp
[modify] https://crrev.com/5f21d5af36aee7b988ab11794720d269f1f20de9/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/5f21d5af36aee7b988ab11794720d269f1f20de9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 7 by khmel@chromium.org, Sep 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment