Show click-through to Doodle on dark-themed NTP |
||
Issue descriptionWith dark themes, the remote NTP does not display doodles. Instead, it shows a spinner, and clicking on it leads to an un-themed NTP with the doodle. The local NTP needs something to handle doodles on dark themes.
,
Sep 21 2017
Yep. I kept it as "something" because I labeled this bug for M-63. I don't know that we need that whole flow for M63, but we should at least turn doodles off for dark themes by then.
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9624c8d7e603d9f0a0a4e962a3dfdd11944bfc commit 2c9624c8d7e603d9f0a0a4e962a3dfdd11944bfc Author: Chris Pickel <sfiera@chromium.org> Date: Mon Sep 25 17:20:08 2017 Add "Click to view today’s doodle" string Bug: 767362 Change-Id: I818e65a48c71cac2ebbd1860b0352df35be9e14d Reviewed-on: https://chromium-review.googlesource.com/678895 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#504084} [modify] https://crrev.com/2c9624c8d7e603d9f0a0a4e962a3dfdd11944bfc/chrome/app/generated_resources.grd
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8 commit 42a20d78ccfa1de4ab6bd534be4f646d6b2100d8 Author: Chris Pickel <sfiera@chromium.org> Date: Thu Sep 28 08:43:05 2017 Local NTP: prompt for doodle on non-white-bg NTP Mostly implemented in CSS for the simplicity of not having to track an additional set of things that might or might not be visible. Bug: 767362 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b1595dbeca52dff41e93a5271b1de59b4d2c430 Reviewed-on: https://chromium-review.googlesource.com/685234 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504946} [modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/test/data/local_ntp/local_ntp_browsertest.html
,
Sep 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by treib@chromium.org
, Sep 21 2017