New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767362 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Show click-through to Doodle on dark-themed NTP

Project Member Reported by sfiera@chromium.org, Sep 21 2017

Issue description

With dark themes, the remote NTP does not display doodles. Instead, it shows a spinner, and clicking on it leads to an un-themed NTP with the doodle.

The local NTP needs something to handle doodles on dark themes.
 

Comment 1 by treib@chromium.org, Sep 21 2017

Probably we shoud do the same thing as the remote NTP: If there's a theme, just show a "notifier" instead of the Doodle, and link to an unthemed NTP, e.g. via a query param. Is that what you had in mind?

Comment 2 by sfiera@chromium.org, Sep 21 2017

Yep. I kept it as "something" because I labeled this bug for M-63. I don't know that we need that whole flow for M63, but we should at least turn doodles off for dark themes by then.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c9624c8d7e603d9f0a0a4e962a3dfdd11944bfc

commit 2c9624c8d7e603d9f0a0a4e962a3dfdd11944bfc
Author: Chris Pickel <sfiera@chromium.org>
Date: Mon Sep 25 17:20:08 2017

Add "Click to view today’s doodle" string

Bug:  767362 
Change-Id: I818e65a48c71cac2ebbd1860b0352df35be9e14d
Reviewed-on: https://chromium-review.googlesource.com/678895
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504084}
[modify] https://crrev.com/2c9624c8d7e603d9f0a0a4e962a3dfdd11944bfc/chrome/app/generated_resources.grd

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8

commit 42a20d78ccfa1de4ab6bd534be4f646d6b2100d8
Author: Chris Pickel <sfiera@chromium.org>
Date: Thu Sep 28 08:43:05 2017

Local NTP: prompt for doodle on non-white-bg NTP

Mostly implemented in CSS for the simplicity of not having to track an
additional set of things that might or might not be visible.

Bug:  767362 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b1595dbeca52dff41e93a5271b1de59b4d2c430
Reviewed-on: https://chromium-review.googlesource.com/685234
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504946}
[modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/resources/local_ntp/local_ntp.html
[modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/42a20d78ccfa1de4ab6bd534be4f646d6b2100d8/chrome/test/data/local_ntp/local_ntp_browsertest.html

Comment 5 by sfiera@chromium.org, Sep 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment