Enforce on metrics and login_manager since the have been clang-formatted already. Add more projects over time. clang-format login_manager and further discussion: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/671048 clang-format metrics: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/506729
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d2a441d9e8e05e14245b62448bf598099464bff0 commit d2a441d9e8e05e14245b62448bf598099464bff0 Author: Lutz Justen <ljusten@chromium.org> Date: Sat Sep 23 07:40:05 2017 Update .clang-format file Switch away from Brillo's clang-format file and make it work more like Chromium. See CL:677192 for the discussion. BUG= chromium:767348 TEST=Ran clang-format on login_manager Change-Id: I2ea64b542d4da470bd6347b13e064014d759ae33 Reviewed-on: https://chromium-review.googlesource.com/678725 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rewrite] https://crrev.com/d2a441d9e8e05e14245b62448bf598099464bff0/.clang-format
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/24159be243aa413116ce4364778840eafc45b1ab commit 24159be243aa413116ce4364778840eafc45b1ab Author: Lutz Justen <ljusten@chromium.org> Date: Mon Sep 25 18:32:19 2017 login: Run clang-format Ran clang-format -i -style=file login_manager/*.cc login_manager/*.h and a few fixed minor formatting issues and the license text in named_platform_handle_utils_posix.cc. No further changes. CQ-DEPEND=CL:678725 BUG= chromium:767348 TEST=Compiles Change-Id: I044a51bb29a80571958b43b586c3147a68593f69 Reviewed-on: https://chromium-review.googlesource.com/671048 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/nss_util.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/chrome_setup.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/matchers.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/login_metrics.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/android_container_manager_impl.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/liveness_checker_impl_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/android_oci_wrapper.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/device_policy_service.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/key_generator.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/session_manager_testrunner.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/user_policy_service.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/generator_job.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/browser_job.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/device_policy_service_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/fake_browser_job.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_object_proxy.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/container_config_parser.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/policy_key.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/regen_mitigator.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_process_manager_service.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_constructors.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/android_oci_wrapper_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/server_backed_state_key_generator_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_device_policy_service.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/container_config_parser.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_policy_service.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/child_job.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/device_policy_service.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/policy_service.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/container_config_parser_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/liveness_checker_impl.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/user_policy_service_factory.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/policy_store_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/session_manager_process_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/session_manager_impl_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/user_policy_service_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/session_manager_main.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/child_exit_handler.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/login_metrics_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/child_job.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/named_platform_handle_utils_posix.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/child_exit_handler.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/fake_generator_job.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/user_policy_service_factory.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/policy_service_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/dbus_util.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/liveness_checker_impl.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/systemd_unit_starter.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/server_backed_state_key_generator.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/fake_child_process.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_system_utils.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/policy_store.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_nss_util.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_nss_util.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/vpd_process_impl.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/keygen_worker.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/fake_generated_key_handler.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/device_local_account_policy_service.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/login_metrics.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/key_generator_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_metrics.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/owner_key_loss_mitigator.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/generator_job.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/key_generator.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/session_manager_impl.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/file_checker.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/fake_generator_job.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/mock_mitigator.h [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/upstart_signal_emitter.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/system_utils_impl.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/cumulative_use_time_metric.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/regen_mitigator_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/vpd_process_impl.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/browser_job_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/session_manager_service.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/chrome_setup_unittest.cc [modify] https://crrev.com/24159be243aa413116ce4364778840eafc45b1ab/login_manager/cumulative_use_time_metric_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c465e2a0b8121610076b751f9c435e2f37715b06 commit c465e2a0b8121610076b751f9c435e2f37715b06 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Oct 04 19:52:19 2017 clang-format: re-enable AllowAllParametersOfDeclarationOnNextLine This style is permitted by the Google & Chromium style guides, and Chromium OS code uses it. Avoid thrashing on existing code. BUG= chromium:767348 TEST=None Change-Id: Ica4598920270343ebb12fcd73cae2ad1dc192c79 Reviewed-on: https://chromium-review.googlesource.com/691343 Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/c465e2a0b8121610076b751f9c435e2f37715b06/.clang-format
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/19f6a1edd49900117655bd6faf9caefde38cf511 commit 19f6a1edd49900117655bd6faf9caefde38cf511 Author: Lutz Justen <ljusten@chromium.org> Date: Thu Oct 05 01:47:09 2017 Enforce clang-format on login_manager Adds a presubmit check that detects format-worthy changes in login_manager (since it has been clang-formatted before). CQ-DEPEND=CL:671048,CL:678725,CL:685283 BUG= chromium:767348 TEST=Tested by making changes to enforced and non-enforced projects Change-Id: I3a17912aca0742f12ffc81208d29cc8e0bb37f40 Reviewed-on: https://chromium-review.googlesource.com/677192 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/19f6a1edd49900117655bd6faf9caefde38cf511/PRESUBMIT.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1bce4e4dde1e1bddb206d46b4ef4c7cc691a7ec9 commit 1bce4e4dde1e1bddb206d46b4ef4c7cc691a7ec9 Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 06 10:57:47 2017 Enforce clang-format on cros-disks, mist, vpn-manager, wimax_manager cros-disks, mist, vpn-manager, and wimax_manager have been re-formatted with clang-format. This CL enforces clang-format check on them. BUG= chromium:767348 TEST=Tested by making changes to enforced and non-enforced projects Change-Id: I384016d32c011781814433e353c6ae659be8b363 Reviewed-on: https://chromium-review.googlesource.com/703467 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/1bce4e4dde1e1bddb206d46b4ef4c7cc691a7ec9/PRESUBMIT.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6a7debc3dcc28fe1ad01d86bda7f37270ffd83cb commit 6a7debc3dcc28fe1ad01d86bda7f37270ffd83cb Author: Daniel Erat <derat@chromium.org> Date: Fri Oct 06 10:57:50 2017 Disable SortIncludes in .clang-format. Disable SortIncludes in the platform2 .clang-format file. clang-format does simple alphabetical sorting of #include lines, which conflicts with the fancier sorting used by cpplint.py, namely (quoting the comment from CanonicalizeAlphabeticalOrder): - replaces "-" with "_" so they both cmp the same. - removes '-inl' since we don't require them to be after the main header. - lowercase everything, just in case. BUG= chromium:767348 TEST=ran clang-format on power_manager/ and checked that it didn't reorder linux/i2c.h and linux/i2c-dev.h in powerd/system/display/external_display.cc Change-Id: I1ae5f42948f13d9a0c5157c8bfcc924566010b1f Reviewed-on: https://chromium-review.googlesource.com/703985 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6a7debc3dcc28fe1ad01d86bda7f37270ffd83cb/.clang-format
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7e6df0a115138ccbfb35d1e3f14dd399c97b6c21 commit 7e6df0a115138ccbfb35d1e3f14dd399c97b6c21 Author: Daniel Erat <derat@chromium.org> Date: Fri Oct 06 15:09:23 2017 Remove TabWidth from .clang-format and add comments. Remove "TabWidth 2" from .clang-format so that we use Chromium's default of 8. We don't use tabs to indent code, so diverging from Chromium here seems unnecessary. Also add comments describing the justifications for other directives. BUG= chromium:767348 TEST=uploading didn't bug me about any currently-watched directories being formatted incorrectly Change-Id: I03fadee4fe2298dea13f50105f33557deb1bf591 Reviewed-on: https://chromium-review.googlesource.com/704058 Tested-by: Dan Erat <derat@chromium.org> Trybot-Ready: Dan Erat <derat@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> [modify] https://crrev.com/7e6df0a115138ccbfb35d1e3f14dd399c97b6c21/.clang-format
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79 commit 5e978a78b864431bb8348f5cfcb1ea1b1b65ad79 Author: Lutz Justen <ljusten@chromium.org> Date: Sat Oct 14 00:22:10 2017 login: Run clang-format Ran clang-format -i -style=file login_manager/*.cc login_manager/*.h again as the clang-format file changed recently. BUG= chromium:767348 TEST=Compiles Change-Id: I045d7478b726cbf6f3b2b92c56d1eb8c5cd9b757 Reviewed-on: https://chromium-review.googlesource.com/712160 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/nss_util.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/mock_constructors.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/liveness_checker_impl_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/device_policy_service_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/mock_object_proxy.h [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/android_oci_wrapper_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/device_local_account_policy_service.h [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/session_manager_service.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/fake_generated_key_handler.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/nss_util.h [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/session_manager_impl.h [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/session_manager_process_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/user_policy_service_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/login_metrics_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/termina_manager_impl.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/user_policy_service_factory.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/session_manager_impl_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/policy_service_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/systemd_unit_starter.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/server_backed_state_key_generator.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/policy_key_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/fake_termina_manager.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/mock_nss_util.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/mock_nss_util.h [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/device_local_account_policy_service.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/key_generator_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/device_local_account_policy_service_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/session_manager_impl.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/server_backed_state_key_generator_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/cumulative_use_time_metric.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/browser_job_unittest.cc [modify] https://crrev.com/5e978a78b864431bb8348f5cfcb1ea1b1b65ad79/login_manager/user_policy_service_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4b00822b182050fff6b005783b18bf8f1f44b6bd commit 4b00822b182050fff6b005783b18bf8f1f44b6bd Author: Lutz Justen <ljusten@chromium.org> Date: Mon Oct 16 16:26:04 2017 authpolicy: Run clang-format Ran clang-format -i -style=file \ $(find authpolicy/ -name '*.h' -o -name '*.cc') since the clang-format file changed recently and enforced clang-format on authpolicy. BUG= chromium:767348 TEST=Compiles Change-Id: I87b210a2e5f9c566cedd2f638d782a0e33610fa0 Reviewed-on: https://chromium-review.googlesource.com/719007 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/process_executor.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/PRESUBMIT.cfg [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/policy/user_policy_encoder.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/samba_helper_unittest.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/authpolicy_metrics.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/policy/device_policy_encoder.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/authpolicy_unittest.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/process_executor_unittest.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/platform_helper.h [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/stub_kinit_main.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/samba_helper.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/policy/policy_encoder_helper.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/policy/preg_policy_writer.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/stub_klist_main.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/platform_helper.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/samba_interface.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/authpolicy_parser_main.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/authpolicy.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/stub_net_main.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/anonymizer.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/policy/preg_policy_encoder_unittest.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/policy/device_policy_encoder_unittest.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/tgt_manager.cc [modify] https://crrev.com/4b00822b182050fff6b005783b18bf8f1f44b6bd/authpolicy/authpolicy_flags.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9f9f66e916f5ebcfdf91cfce140e49e603aca046 commit 9f9f66e916f5ebcfdf91cfce140e49e603aca046 Author: Luis Hector Chavez <lhchavez@google.com> Date: Thu Oct 19 02:08:27 2017 run_oci: Run clang-format This change runs clang-format in order to add run_oci to the list of projects that run clang-format in PRESUBMIT.cfg BUG= chromium:767348 TEST=repo upload Change-Id: I742ad7be2585810090c28bc0eadf07ed2027effd Reviewed-on: https://chromium-review.googlesource.com/723661 Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org> Tested-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/run_oci/container_config_parser.cc [modify] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/PRESUBMIT.cfg [modify] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/run_oci/container_options.h [modify] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/run_oci/run_oci.cc [modify] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/run_oci/container_config_parser_unittest.cc [modify] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/run_oci/oci_config.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d3e54f3f5ad6eec03b312e66a4c2927cfe106c25 commit d3e54f3f5ad6eec03b312e66a4c2927cfe106c25 Author: Ben Chan <benchan@chromium.org> Date: Sun Dec 17 12:20:46 2017 Enforce clang-format on libpasswordprovider and smbprovider. libpasswordprovider and smbprovider are already formatted with clang-format. This CL enforces clang-format check on them. BUG= chromium:767348 TEST=Tested by making changes to enforced and non-enforced projects. Change-Id: I8f19965e4c7122acff79c6c65268935156968e54 Reviewed-on: https://chromium-review.googlesource.com/830526 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d3e54f3f5ad6eec03b312e66a4c2927cfe106c25/PRESUBMIT.cfg
Comment 1 by bugdroid1@chromium.org
, Sep 23 2017