New issue
Advanced search Search tips

Issue 767344 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 785462
issue 784774
issue 785104

Blocking:
issue 712444
issue 767298



Sign in to add a comment

build triggering for chromium waterfall builders on LUCI

Project Member Reported by no...@chromium.org, Sep 21 2017

Issue description

Chromium waterfall buildbot use "trigger" recipe module that does not work on LUCI. Triggering needs to continue to work on LUCI.


 

Comment 1 by no...@chromium.org, Sep 21 2017

ideally we should not change buildbot code paths to achieve it, to minimize the risk of breaking waterfalls, closing trees, etc

proposal:
1) create a service account and specify it in the builder_defaults of the upcoming luci.chromium.continuous bucket, so that all continuous builds have a task service account
2) modify trigger module: on LUCI
   - use buildbucket recipe module to trigger an equivalent build
   - use the service account in LUCI context for authentication

Vadim, WDYT?

Comment 2 by efoo@chromium.org, Oct 6 2017

Blocking: 712444

Comment 3 by efoo@chromium.org, Oct 6 2017

Any thoughts on this Vadim?
Plan sgtm. Service accounts part should work already. Buildbucket recipe module is not yet ready, but it will be soon (https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/701501 and a bunch of follow up CLs to make Chromium recipe use this stuff).

Comment 5 by no...@chromium.org, Nov 14 2017

Cc: tandrii@chromium.org
Components: Infra>Platform
Labels: LUCI-Blocker-M4
tandrii, i've just (re)dicovered this bug. Did you work on anything intersecting with this?
Blocking: 767298
Owner: tandrii@chromium.org
Status: Started (was: Assigned)
I followed bug filed by V8 for which Vadim implemented buildbucket module (see from https://crbug.com/769776#c14) . I've been adapting it to chromium recipe already, so i'm taking this bug.
correction:
  s/adapting it/making use of it


Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b06a1f1b10b353d1c817e2ada953c59e6947a460

commit b06a1f1b10b353d1c817e2ada953c59e6947a460
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Nov 14 02:04:18 2017

Deprecate trigger recipe module in favor recipe_engine/buildbucket.

Bug:  767344 
Change-Id: I5987b623a1dbd598e51a9f1084ca185661309625
Reviewed-on: https://chromium-review.googlesource.com/767856
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b06a1f1b10b353d1c817e2ada953c59e6947a460/scripts/slave/recipe_modules/trigger/README.md

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/98e1ca82fc0c903dc4a75eae6f34b234e0aec28b

commit 98e1ca82fc0c903dc4a75eae6f34b234e0aec28b
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Nov 14 03:24:43 2017

Blockedon: 784774
led got even better in last 5 months, so I made progress:

https://ci.chromium.org/swarming/task/39d25ba819f34110?server=chromium-swarm.appspot.com 



Project Member

Comment 11 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e707f0f56df397e931d505a092352d937066c4ca

commit e707f0f56df397e931d505a092352d937066c4ca
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Nov 14 17:51:21 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/1e821f5586b600c8f11f106577dcacdf4abf1584

commit 1e821f5586b600c8f11f106577dcacdf4abf1584
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Nov 14 18:07:31 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4c5f4f9a55a2e5ab58d457f999f4d5197e8d858c

commit 4c5f4f9a55a2e5ab58d457f999f4d5197e8d858c
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Nov 14 20:30:45 2017

Blockedon: 785104

Comment 15 by no...@chromium.org, Nov 16 2017

Blockedon: 785462
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/86bef365808566261033cace1b0ad8ade6aa2cdf

commit 86bef365808566261033cace1b0ad8ade6aa2cdf
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Nov 16 19:45:03 2017

chromium_tests: use buildbucket for triggering when running on LUCI.

Bug:  767344 
Change-Id: I9651845eaaee00095145390c7ad09094c479325b
Reviewed-on: https://chromium-review.googlesource.com/767768
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/recipe_modules/chromium_tests/__init__.py
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/README.recipes.md
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/.gitattributes
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
[modify] https://crrev.com/86bef365808566261033cace1b0ad8ade6aa2cdf/scripts/slave/recipe_modules/chromium_tests/api.py

Comment 17 by efoo@chromium.org, Nov 17 2017

Labels: REQBY-LUCI-M4a-MacWinPOC LUCI-M3-S12 LUCI-M3-Beta
Add labels for tracking. 
Actually, this already works: https://ci.chromium.org/p/chromium/consoles/sandbox-side-by-side 


hooray.png
237 KB View Download
Status: Fixed (was: Started)

Comment 21 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 22 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-Blocker-M4 -LUCI-M3-Beta luci-blocker-migration

Comment 23 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets

Sign in to add a comment