New issue
Advanced search Search tips

Issue 767339 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContextMenuJsTest are disabled

Project Member Reported by gambard@chromium.org, Sep 21 2017

Issue description

Some ContextMenuJsTest are failing on iOS 11 iPhone devices.
I am disabling TextAreaStopsProximity and GetImageUrlAtPoint.
They need to be reenabled
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b707ba42fe1ea6bb83fdae779e2a9b266f16b0b

commit 7b707ba42fe1ea6bb83fdae779e2a9b266f16b0b
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Sep 21 08:47:51 2017

Disable ContextMenuJsTest tests

TextAreaStopsProximity and GetImageUrlAtPoint are failing on iOS 11
iPhone devices. This is disabling them.

Bug:  767339 
Tbr: eugenebut@chromium.org
Change-Id: I6f081d5ded1f22c80d2360aef262ea95ad0abb99
Reviewed-on: https://chromium-review.googlesource.com/676846
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503393}
[modify] https://crrev.com/7b707ba42fe1ea6bb83fdae779e2a9b266f16b0b/ios/web/web_state/js/context_menu_js_unittest.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc7bc7e19fe79f1dd5215698f5c78a801ec76052

commit fc7bc7e19fe79f1dd5215698f5c78a801ec76052
Author: Eugene But <eugenebut@google.com>
Date: Mon Sep 25 21:16:40 2017

Re-enabled ContextMenuJsTest on device.

The test were probably failing because the page did not finish layout
after the load. Grabbing an HTML element forces layout and makes page
prepared for the testing.

This is a speculative fix, because I could not reproduce the failure
locally.

Bug:  767339 
Change-Id: Id261b4d531b728a52ac7cb9276553bdb6978961e
Reviewed-on: https://chromium-review.googlesource.com/682396
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504165}
[modify] https://crrev.com/fc7bc7e19fe79f1dd5215698f5c78a801ec76052/ios/web/web_state/js/context_menu_js_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment