New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767330 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Overlapping of grey focus highlight is seen in 'Sources' section of devtools.

Reported by rp...@etouch.net, Sep 21 2017

Issue description

Version: 61.0.3163.100 57c9d07b416b5a2ea23d28247300e4af36329bdc-refs/branch-heads/3163@{#1250}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools 
2. Now go to 'Sources' section and press 'Ctrl + P' to open any file
3. Now resize devtool window to RHS and 'Hide debugger' window to RHS and hover mouse cursor on more actions icon '>>' and press tab key to bring focus on 'Hide debugger' button,observe

Actual: Overlapping of grey focus highlight is seen
Expected: Overlapping of grey focus highlight should not be seen

This is a non-regression issue, seen from M-59 series as Grey focus highlight on 'Hide debugger' button in devtools appears from build # 59.0.3059.0

Kindly review the attached video and screenshot for reference.
 
Actual_video.mp4
1.3 MB View Download
Actual_screenshot.png
147 KB View Download
Status: Untriaged (was: Unconfirmed)
Changing the status to Untriaged, so that the issue would get addressed.
Thank You.

Comment 2 by alph@chromium.org, Oct 10 2017

Components: -Platform>DevTools Platform>DevTools>UX
Labels: -Pri-2 Pri-3
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27bff87cd3d3380695d776e3ca969ba04f8a78d8

commit 27bff87cd3d3380695d776e3ca969ba04f8a78d8
Author: Erik Luo <luoe@chromium.org>
Date: Tue Dec 12 00:54:39 2017

DevTools: increase minimum width for sources view

This prevents the 'show more' chevron from overlapping with the split widget's
'hide debugger' button.

Screenshot: https://imgur.com/a/5ByuK

Bug:  767330 
Change-Id: I77212e20d2e85605c168e4e5845dccd2efa1399a
Reviewed-on: https://chromium-review.googlesource.com/815903
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523276}
[modify] https://crrev.com/27bff87cd3d3380695d776e3ca969ba04f8a78d8/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Comment 4 by l...@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment