Create Gitiles change log links for polled repo (not just build and depot_tools) |
|||||
Issue descriptionI've seen the super-useful Gitiles log links that are printed as part of the update_scripts step. They provide links to what changes happened in the following repos between the last build and this build: * build (https://chromium.googlesource.com/chromium/tools/build/+log/) * depot_tools (https://chromium.googlesource.com/chromium/tools/depot_tools/+log/) The code for generating this is located here: https://cs.corp.google.com/chromium_build/scripts/slave/update_scripts.py?rcl=91d53fd3718d59bbbfbfe668dfa47c7a17d591e8&l=149 For troubleshooting reasons, it would be awesome if similar links were generated for the main polled repo for builders in waterfalls. Even more useful when there are two repos that are pinned to HEAD, like for WebRTC's builders in chromium.webrtc.fyi waterfall, that have both src/ and src/third_party/webrtc pinned to HEAD. It's a lot of copy-pasting revisions when those builders break in order to come up with the correct changelog. Setting Infra>Platform>Buildbot component initially to check if this is something that can be done generically rather than only for a specific repo (like WebRTC). CC: martiniss@chromium.org, phajdan.jr@chromium.org who seems to have done the work for update_scripts.
,
Sep 21 2017
It won't be trivial to add that, because update_scripts is not responsible for setting the revision for src, or anything in DEPS like src/third_party/webrtc. bot_update is responsible for that, AFAIK. The logic isn't very complicated though, so it could probably be copy pasted. I could imagine bot_update could emit similar log links. +hinoka for that. IIRC robbie had some ideas about wanting to do this, so cc-ing him as well. I'm not really working in this area much anymore, but I do think this would be a great idea, and would be glad to do some code reviews.
,
Sep 23 2017
,
Sep 24
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 28
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kjellander@chromium.org
, Sep 21 2017