New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767327 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Can't inline reply on Android notifications using touch

Project Member Reported by edcourtney@chromium.org, Sep 21 2017

Issue description

But, using the mouse works.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fcfec640f62098a4e8b2196b09e7566a5576e26

commit 5fcfec640f62098a4e8b2196b09e7566a5576e26
Author: Eliot Courtney <edcourtney@google.com>
Date: Thu Sep 21 07:43:15 2017

Also take focus for notifications on tap.

Previously, you could inline reply on a notification only using the
mouse.

Bug:  767327 
Bug: b/66215638
Change-Id: I4999ade9bb7d07e5d81c5d8e2451600652c04521
Reviewed-on: https://chromium-review.googlesource.com/676687
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503382}
[modify] https://crrev.com/5fcfec640f62098a4e8b2196b09e7566a5576e26/ui/arc/notification/arc_notification_content_view.cc

Comment 2 by kinaba@chromium.org, Sep 22 2017

The fix is needed to pass CTS-V on M-62 for devices w/o builtin mouse-like devices.
(M-62 is the first version that ships such devices with Android-N.)


For M-61, it is not strictly necessary for the launch, but the change looks extremely safe and the bug it fixes looks to be a very bad UX for users that exclusively uses touch screen. How about merging both to M61 and M62?
Cc: uekawa@chromium.org kinaba@chromium.org
Labels: Merge-Request-62 Merge-Request-61
Requesting merge to M62 and M61~~~

Comment 4 by kinaba@chromium.org, Sep 22 2017

Labels: -Pri-2 Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 22 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Request-61 -Merge-Review-62 Merge-Approved-62 Merge-Rejected-61
Approved for 62.

For 61 we are getting too late, if we can get by without it we should. 
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6002c20bf6b2d0fb7e488208e623a4e3c9e60882

commit 6002c20bf6b2d0fb7e488208e623a4e3c9e60882
Author: Eliot Courtney <edcourtney@google.com>
Date: Wed Sep 27 04:25:34 2017

Also take focus for notifications on tap.

Previously, you could inline reply on a notification only using the
mouse.

Bug:  767327 
Bug: b/66215638
Change-Id: I4999ade9bb7d07e5d81c5d8e2451600652c04521
Reviewed-on: https://chromium-review.googlesource.com/676687
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503382}(cherry picked from commit 5fcfec640f62098a4e8b2196b09e7566a5576e26)
Reviewed-on: https://chromium-review.googlesource.com/686134
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#464}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6002c20bf6b2d0fb7e488208e623a4e3c9e60882/ui/arc/notification/arc_notification_content_view.cc

Status: Fixed (was: Started)
Merged so closing.
Labels: -Merge-Rejected-61 Merge-Request-61
Please see b/67451392
Status: Assigned (was: Fixed)
I guess this issue is still not fixed. With click on inline reply button on Hangout ARC notification, an error message popped up as 'System UI has stopped'.
Please refer the attachment.

Logs in this link:
https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/767327/
Screenshot 2017-11-13 at 17.55.46.png
942 KB View Download
Status: Fixed (was: Assigned)
Hi, I had a look at the log and this is a separate issue. I'll make a bug for it. Thanks~!
oops I was doing the same thing :) =>  Bug 784705 
Status: Verified (was: Fixed)
Verified on M64 dev build (10146.0.0, 64.0.3272.0).

Sign in to add a comment