After M62 launches, remove the mailto: alternatives listed in ios/c/b/web/features.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3223a9ace4c2ede824517fd4e9625853bc7c874b commit 3223a9ace4c2ede824517fd4e9625853bc7c874b Author: Peter K. Lee <pkl@chromium.org> Date: Fri Oct 27 22:11:18 2017 Removed unnecessary Feature Flags for mailto handlers. Feature has launched and kill-switch and alternative implementations are no longer necessary. Bug: 767315 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic12d7cc9710794cf424eaf3214885b8ca8971e97 Reviewed-on: https://chromium-review.googlesource.com/741441 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#512318} [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.mm [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller_unittest.mm [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/3223a9ace4c2ede824517fd4e9625853bc7c874b/ios/chrome/browser/web/external_app_launcher.mm [delete] https://crrev.com/a4503529b9998ffca9494aa8ba3c56b33fab7c24/ios/chrome/browser/web/features.h [delete] https://crrev.com/a4503529b9998ffca9494aa8ba3c56b33fab7c24/ios/chrome/browser/web/features.mm [delete] https://crrev.com/a4503529b9998ffca9494aa8ba3c56b33fab7c24/ios/chrome/browser/web/legacy_mailto_url_rewriter.h [delete] https://crrev.com/a4503529b9998ffca9494aa8ba3c56b33fab7c24/ios/chrome/browser/web/legacy_mailto_url_rewriter.mm [delete] https://crrev.com/a4503529b9998ffca9494aa8ba3c56b33fab7c24/ios/chrome/browser/web/legacy_mailto_url_rewriter_unittest.mm
"Mailto Handler Prompt for User choice" feature flag is no longer present in Chrome://flags in build 64.0.3254.0 Canary on both iPhone6+, iPad Pro 12'5 iOS 10.3.3, 11.1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/980a1b5a1c6f0d1699d9a582d03bdc16249a7223 commit 980a1b5a1c6f0d1699d9a582d03bdc16249a7223 Author: Peter K. Lee <pkl@chromium.org> Date: Mon Dec 11 07:57:04 2017 Collapsed NullableMailtoURLRewriter into MailtoHandlerManager MailtoURLRewriter was intended to be the abstract interface when there are more than one implementation of MailtoURLRewriters. Now that the other implementations have been deprecated, there's only one and the two can be collapsed into a single class. The term, MailtoURLRewriter, feels too close to URLRewriter which already has an unrelated meaning, so the collapsed class is given a new name, MailtoHandlerManager, at the same time. Bug: 767315 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I964c176bb93a49f265116d3e3c384763a2cf4709 Reviewed-on: https://chromium-review.googlesource.com/806651 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#523054} [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/external_app/open_mail_handler_view_controller.h [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/external_app/open_mail_handler_view_controller.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/external_app/open_mail_handler_view_controller_unittest.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.h [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller_unittest.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.h [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/external_app_launcher.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/fake_mailto_handler_helpers.h [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/fake_mailto_handler_helpers.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/mailto_handler.h [add] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/mailto_handler_manager.h [rename] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/mailto_handler_manager.mm [add] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/mailto_handler_manager_unittest.mm [modify] https://crrev.com/980a1b5a1c6f0d1699d9a582d03bdc16249a7223/ios/chrome/browser/web/mailto_handler_system_mail.mm [delete] https://crrev.com/e329c0fb358dbb83e65038b4eb48465f9288c3c0/ios/chrome/browser/web/mailto_url_rewriter.h [delete] https://crrev.com/e329c0fb358dbb83e65038b4eb48465f9288c3c0/ios/chrome/browser/web/mailto_url_rewriter.mm [delete] https://crrev.com/e329c0fb358dbb83e65038b4eb48465f9288c3c0/ios/chrome/browser/web/nullable_mailto_url_rewriter.h [delete] https://crrev.com/e329c0fb358dbb83e65038b4eb48465f9288c3c0/ios/chrome/browser/web/nullable_mailto_url_rewriter_unittest.mm
Comment 1 by bugdroid1@chromium.org
, Oct 27 2017