New issue
Advanced search Search tips

Issue 767300 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chrome on Chrome OS won't attempt network geolocation if zero Wifi networks are visible

Project Member Reported by amoylan@chromium.org, Sep 21 2017

Issue description

Conditions: Chrome on Chrome OS, zero Wifi networks are available
Expected:  Should still make network geolocation requests (for IP-based location)
Actual (in integration test environment): No network geolocation request is made

----

I ran into this while trying to create an integration test verifying that Chrome issues a network geolocation request to the correct URL including correct Google API key (to help with  crbug.com/748921 ).

I found that, on Chrome OS, my test failed because no network geolocation request was issued.

Digging into it, this is because Chrome OS treats "zero Wifi networks found" as a signal to keep waiting, rather than returning the empty list to NetworkLocationProvider.

Specifically, in device/geolocation/wifi_data_provider_chromeos.cc:
WifiDataProviderChromeOs::DidWifiScanTaskNoResults does not call RunCallbacks().

Code archaeology: DidWifiScanTaskNoResults actually used to call RunCallbacks(), but it was removed in crrev.com/23889009 as a fix/workaround to resolve crbug.com/236418.

Possible fixes:
* Make wifi_data_provider_chromeos "eventually" (10 seconds?) give up and actually return the zero networks.
* Better: Figure out how to distinguish between "zero networks found because scanning is still happening" vs "zero networks found and scanning is finished".

Severity:
I suspect this would be a super rare one to see in practice simply because it would require Chrome OS to be connected to the internet but not be able to see any Wifi networks. (I haven't tried to reproduce those conditions myself to see this in a prod situation.)


 
Labels: OS-Chrome
Components: Blink>Geolocation
Components: -Blink>Location
Status: Available (was: Unconfirmed)
Cc: -scheib@chromium.org
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by reillyg@chromium.org, Jan 16 (6 days ago)

Cc: mattreynolds@chromium.org
Status: Available (was: Untriaged)

Sign in to add a comment