New issue
Advanced search Search tips

Issue 767299 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

BridgedNativeWidgetUITest.HitTest is flaky on Mac10.12 Tests

Project Member Reported by tapted@chromium.org, Sep 21 2017

Issue description

interactive_ui_tests failing on chromium.mac/Mac10.12 Tests

Builders failed on: 
- Mac10.12 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests

Error like

[ RUN      ] BridgedNativeWidgetUITest.HitTest
[2236:775:0920/194914.734994:67977968658883:ERROR:native_widget_mac.mm(281)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
[2236:775:0920/194914.762856:67977996513802:ERROR:native_widget_mac.mm(281)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:425: Failure
Value of: [did_move_observer wait]
  Actual: false
Expected: true
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:426: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:432: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:484: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:508: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:514: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:529: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:535: Failure
      Expected: 120
To be equal to: [window frame].origin.x
      Which is: 110
[  FAILED  ] BridgedNativeWidgetUITest.HitTest (11688 ms)


I couldn't get this to fail locally. I think there are some 10.12 bots with a bogus setup for running interactive_ui_tests that causes the mouse events to hit the wrong window.
 

Comment 2 by tapted@chromium.org, Sep 21 2017

The job that ran on vm1508-m4 wasn't flaky at all
 - https://chromium-swarm.appspot.com/task?id=38baf4169e14aa10&refresh=10&show_raw=1

vm1330-m4, vm1271-m4 and vm1342-m4 failed
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4474fd035f77c2addad4d7f92568178b6d45d309

commit 4474fd035f77c2addad4d7f92568178b6d45d309
Author: Trent Apted <tapted@chromium.org>
Date: Thu Sep 21 04:17:39 2017

Disable flaky interactive_ui_test BridgedNativeWidgetUITest.HitTest.

Fails on some swarming bots in the 10.12 pool.

Bug: 767299
Change-Id: Ib8bdadd33f0e17c39959052a78c7769b09b9fc89
Reviewed-on: https://chromium-review.googlesource.com/676823
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503349}
[modify] https://crrev.com/4474fd035f77c2addad4d7f92568178b6d45d309/ui/views/cocoa/bridged_native_widget_interactive_uitest.mm

Labels: -Sheriff-Chromium
Removing from sheriff queue, since the flaky test is now disabled.
Components: Tests>Disabled
Labels: Test-Disabled
Cc: linds...@chromium.org
Labels: Hotlist-DisableReview
@tapted can you ptal at this disable as it reduces automated test coverage?

Sign in to add a comment