New issue
Advanced search Search tips

Issue 767295 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

views_unittests: Some tests don't have a Widget::FocusManager

Project Member Reported by tapted@chromium.org, Sep 21 2017

Issue description

Chrome Version       : 63.0.3213.3
OS Version: OS X 10.12.6

5 tests crashed:
    CompositingWidgetTest.Transparency_DesktopWidgetInferOpacity (../../ui/views/widget/widget_unittest.cc:3934)
    CompositingWidgetTest.Transparency_DesktopWidgetOpaque (../../ui/views/widget/widget_unittest.cc:3938)
    CompositingWidgetTest.Transparency_DesktopWidgetTranslucent (../../ui/views/widget/widget_unittest.cc:3942)
    NativeWidgetMacTest.ReparentNativeViewTypes (../../ui/views/widget/native_widget_mac_unittest.mm:1747)
    NativeWidgetTest.GetTopLevelNativeWidget2 (../../ui/views/widget/native_widget_unittest.cc:84)

E.g. with

void NativeWidgetMac::InitNativeWidget(const Widget::InitParams& params) {
  delegate_->OnNativeWidgetCreated(true);
  DCHECK(GetWidget()->GetRootView());  // Fine.
  DCHECK(GetWidget()->GetFocusManager());  // Fails.
...
}

I'm suggesting in https://chromium-review.googlesource.com/c/chromium/src/+/670479 that we add a check, but it's possible we don't want to support this use case.
 
Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment