New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767293 link

Starred by 2 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Sep 2017
Cc:
█ scottchen@chromium.org
dpa...@chromium.org
█ dschuyler@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Settings: assertion hit when leaving Autofill/Fonts pages

Project Member Reported by dbeam@chromium.org, Sep 21 2017 
repro steps:
0. navigate to chrome://settings
1. click on either "Customize fonts" or "Autofill settings" (in advanced)
2. use in page back button (looks like: <-)

what do you expect?
no assertion

what do you see instead?
assertion error (see attached)
2017-09-20-192909_939x668_scrot.png
80.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2e18cfe9bf24502206b268e6c88bb3b6d03a464

commit b2e18cfe9bf24502206b268e6c88bb3b6d03a464
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Sep 21 18:00:05 2017

Settings: fix assertion failures when leaving Autofill/Fonts pages

R=dschuyler@chromium.org
BUG= 767293 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If85e5a303f85b7d77ff5a4bc3b10b1e7ecf62d57
Reviewed-on: https://chromium-review.googlesource.com/675846
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503501}
[modify] https://crrev.com/b2e18cfe9bf24502206b268e6c88bb3b6d03a464/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/b2e18cfe9bf24502206b268e6c88bb3b6d03a464/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Comment 2 by dbeam@chromium.org, Sep 21 2017

Status: Fixed (was: Started)
fwiw: I didn't audit the codebase that hard for other occurrences
►

Sign in to add a comment