New issue
Advanced search Search tips

Issue 767287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

Scheduler: remove raw swarming task support

Project Member Reported by tandrii@chromium.org, Sep 21 2017

Issue description

It's not actually used, and can easily be used through buildbucket jobs.
Furthermore, unlike current scheduler's support, buildbucket actually allows rich configs with CIPD packages and other stuff.
 
Labels: -Restrict-View-Google
Vadim, please confirm and assign to me for execution.
Owner: tandrii@chromium.org
I don't know, I'm on the fence. On one hand I can see raw Swarming tasks being useful, on the other hand, no one is actually using them or plans to use them :-/

Considering Swarming task implementation in Scheduler is very similar to Buildbucket task implementation, I think we'll be able to "restore" it later, if needed, using Buildbucket task implementation as a template.

So yeah, let's kill it for now.

Comment 3 by no...@chromium.org, Sep 21 2017

Labels: -Pri-2 Pri-1
let's bump priority cause deleting code is fun
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5377278f0bbf327950f2238393182e44649deee1

commit 5377278f0bbf327950f2238393182e44649deee1
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 30 21:47:59 2017

scheduler: log warnings if raw swarming jobs are defined.

End goal is to remove raw swarming job support from scheduler.

R=vadimsh@chromium.org

Bug:  767287 
Change-Id: I4ab3535589ac140cfa8111780b241d4c917c14b3
Reviewed-on: https://chromium-review.googlesource.com/742696
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/5377278f0bbf327950f2238393182e44649deee1/scheduler/appengine/catalog/catalog.go

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/788a7c3fa47407b4787cd01fba14d9d548938fc0

commit 788a7c3fa47407b4787cd01fba14d9d548938fc0
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 30 21:53:27 2017

Delete swarming-sleepy-job, raw swarming tasks won't be supported.

TBR=vadimsh@chromium.org

Bug:  767287 
Change-Id: Ibf3429d979d69f77ce2954b55edd8429b238e21e
Reviewed-on: https://chromium-review.googlesource.com/744969
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/788a7c3fa47407b4787cd01fba14d9d548938fc0/luci-scheduler-dev.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c772afdef3c5cb053edad57a33b476a1c375a839

commit c772afdef3c5cb053edad57a33b476a1c375a839
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 30 22:01:58 2017

scheduler: fail validation for raw swarming jobs.

End goal is to remove raw swarming job support from scheduler.

R=vadimsh@chromium.org

Bug:  767287 
Change-Id: Ie091f5dab849a7498b9b96c64b685f2030459ceb
Reviewed-on: https://chromium-review.googlesource.com/742697
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/c772afdef3c5cb053edad57a33b476a1c375a839/scheduler/appengine/catalog/catalog.go
[modify] https://crrev.com/c772afdef3c5cb053edad57a33b476a1c375a839/scheduler/appengine/messages/cron.pb.go
[modify] https://crrev.com/c772afdef3c5cb053edad57a33b476a1c375a839/scheduler/appengine/messages/cron.proto

Comment 8 Deleted

Status: Fixed (was: Assigned)
Deployed to prod and dev as version 2240-9136a96 

Sign in to add a comment