New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767282 link

Starred by 2 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Sep 25
Cc:
billorr@chromium.org
█ vollick@chromium.org
tiborg@chromium.org
mthiesse@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 865486
issue 875291
Blocking:
issue 776908
issue 778374



Sign in to add a comment

Extract cross platform portions from VrShellGl

Project Member Reported by cjgrant@chromium.org, Sep 21 2017 
We want to pull common pieces of VrShellGl out to separate modules, and cleaning up interfaces.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1862fb1f7983f4912766deed5326e12af3983fbe

commit 1862fb1f7983f4912766deed5326e12af3983fbe
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Sep 22 15:59:43 2017

VR: Clean up browser to UI interfaces.

This change is preparation for refactoring of the VR UI object
structure.

BUG= 767282 

Change-Id: I03a1cd49cd4a9a75ca96e8c46148bd3fb31feb9c
Reviewed-on: https://chromium-review.googlesource.com/676487
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503751}
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/gl_browser_interface.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/android/vr_shell/vr_web_contents_observer.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/vr/toolbar_helper.cc
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/vr/toolbar_helper.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/1862fb1f7983f4912766deed5326e12af3983fbe/chrome/browser/vr/ui_scene_manager.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2a33464ea130c6c909a24858cddf04479e35e4

commit 6f2a33464ea130c6c909a24858cddf04479e35e4
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Sep 22 22:56:40 2017

VR: Explicitly indicate GLSL version in shaders

This makes the shaders happier when compiling on linux. The shader
version is currently 1.0.

BUG= 767282 

Change-Id: I5d953e47762c7c8309ebc937aa5c48ecc0718a6f
Reviewed-on: https://chromium-review.googlesource.com/679296
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503897}
[modify] https://crrev.com/6f2a33464ea130c6c909a24858cddf04479e35e4/chrome/browser/vr/vr_shell_renderer.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea69a470367f45ef9c98b9cb79d540c689154d0d

commit ea69a470367f45ef9c98b9cb79d540c689154d0d
Author: Christopher Grant <cjgrant@chromium.org>
Date: Mon Sep 25 15:23:32 2017

VR: Split UI components out of VrShellGl

This change creates a vr::Ui object, housing all Skia UI pieces. This
builds separation of the UI implementation from the Android-specific
rendering code.

More cleanup along the way.

BUG= 767282 

Change-Id: I5c1faf6abc71d3c57c73435a4cd37e86ec447217
Reviewed-on: https://chromium-review.googlesource.com/679194
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504059}
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/test/ui_scene_manager_test.cc
[add] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/ui.cc
[add] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/ui.h
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/chrome/browser/vr/ui_scene_manager.h

Comment 4 by vollick@chromium.org, Oct 20 2017

Blocking: 776908

Comment 5 by cjgrant@chromium.org, Nov 7 2017

Cc: -vollick@chromium.org mthiesse@chromium.org
Owner: vollick@chromium.org
Ian, tossing this to you as you're working on it.  As discussed,  issue 778374  should likely be duped into this one, or vice-versa.

Comment 6 by vollick@chromium.org, Nov 7 2017

Blocking: 778374

Comment 7 by ymalik@chromium.org, Feb 5 2018

Cc: billorr@chromium.org
Summary: Refactor WebVR specific portions from VrShellGl for Windows (was: Refactor VrShellGl and associated code to be cross-platform)

Comment 8 by acondor@chromium.org, Jul 16

Owner: acondor@chromium.org
Status: Assigned (was: Started)

Comment 9 by vollick@chromium.org, Jul 16

Cc: vollick@chromium.org

Comment 10 by btebbs@chromium.org, Jul 16

Labels: VR-Desktop

Comment 11 by btebbs@chromium.org, Jul 16

Labels: VR-Desktop-UI

Comment 12 by acondor@chromium.org, Jul 19

Blockedon: 865486

Comment 13 by acondor@chromium.org, Jul 23

Summary: Extract cross platform portions from VrShellGl (was: Refactor WebVR specific portions from VrShellGl for Windows)

Comment 14 by acondor@chromium.org, Jul 23

Description: Show this description

Comment 15 by acondor@chromium.org, Jul 23

Description: Show this description

Comment 17 by acondor@chromium.org, Aug 1

Blockedon: 869975
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc004c7f588c13626ee7dc640e4ac922a6c60a99

commit cc004c7f588c13626ee7dc640e4ac922a6c60a99
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Thu Aug 02 14:50:02 2018

VR: Add a controller delegate for VrShellGl

A controller delegate is responsible for updating the controller, detect
gestures and produce a model to be sent to the Ui. This CL introduces 2
delegates for VrShellGl, one for production and one for testing.

This is the first step on a major refactoring on which VrShellGl
disappears in favor of a cross platform RenderLoop, composed of platform
specific delegates for each of its functions.

A revert to https://crrev.com/c/1121670 was needed to get the
chrome_public_test_vr_apk built properly.

Bug:  767282 ,  848494 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib68f975ce4e5e39fc7ebb5cf386b400f48039f4e
Reviewed-on: https://chromium-review.googlesource.com/1151623
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580178}
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/build/config/android/rules.gni
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserDialogTest.java
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/BUILD.gn
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/controller_delegate_for_testing.cc
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/controller_delegate_for_testing.h
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/gvr_controller_delegate.cc
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/gvr_controller_delegate.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/vr_controller.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/DEPS
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/controller_delegate.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/model/controller_model.h
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/render_loop.cc
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/render_loop.h
[add] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/test/constants.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/test/constants.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/ui.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/ui.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/ui_test_input.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/cc004c7f588c13626ee7dc640e4ac922a6c60a99/chrome/browser/vr/vr_geometry_util_unittest.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41532413e45f7746bf0ac3f28abd951c30531b58

commit 41532413e45f7746bf0ac3f28abd951c30531b58
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Tue Aug 07 22:36:44 2018

VR: Extract update UI logic to RenderLoop

Also performing the UI update after obtaining a frame.

Bonus: replace __FUNCTION__ by __func__ to comply to styleguide.

Bug:  767282 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I88f59a2991f8fed1ce7d9842781d2d63d8b351fa
Reviewed-on: https://chromium-review.googlesource.com/1162702
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581375}
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/android/vr/gl_browser_interface.h
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/vr/render_loop.cc
[modify] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/vr/render_loop.h
[add] https://crrev.com/41532413e45f7746bf0ac3f28abd951c30531b58/chrome/browser/vr/render_loop_browser_interface.h
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4d79651f29db1cb0264b84b38912a0a1f294af

commit 7e4d79651f29db1cb0264b84b38912a0a1f294af
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed Aug 15 19:11:54 2018

Rename GraphicsDelegate to CompositorDelegate

The compositor delegate will own and manage the surfaces, viewports and
buffers. The newly added public interface restricts the manipulation of
contexts to the client (RenderLoop). A native GL implementation is
provided.

Bug:  767282 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I23138f85ba859a64cbcc60c2d8f32757ec941f22
Reviewed-on: https://chromium-review.googlesource.com/1173394
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583349}
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/base_compositor_delegate.cc
[add] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/base_compositor_delegate.h
[add] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/compositor_delegate.h
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/elements/platform_ui_element.cc
[delete] https://crrev.com/b3cb7284a4c178c900519d45379ce741d22c10db/chrome/browser/vr/graphics_delegate.cc
[delete] https://crrev.com/b3cb7284a4c178c900519d45379ce741d22c10db/chrome/browser/vr/graphics_delegate.h
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/render_loop.cc
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/render_loop.h
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/test/gl_test_environment.cc
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/test/gl_test_environment.h
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/testapp/gl_renderer.cc
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/7e4d79651f29db1cb0264b84b38912a0a1f294af/chrome/browser/vr/testapp/vr_test_context.h
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173c0a14bc75fbc768aaa22440fc4b8d366a3221

commit 173c0a14bc75fbc768aaa22440fc4b8d366a3221
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Thu Aug 16 15:39:08 2018

VR: Add RenderLoopFactory for android

The RenderLoopFactory is responsible of instantiating the delegates
that Ui and RenderLoop require. In this CL, we are still instantiating
a VrShellGl object, as the split-up has not been completed yet. Also, we
make sure that the variables passed to VrGLThread are freed once the
RenderLoop has been built.

The testapp starts to be prepared to make use of RenderLoop. We simplify
the VrTestContext creation (soon to be the RenderLoop) by initializing it
once a GL context was set.

Bug= 767282 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie0f580f77fb109463dc41093919a7c535976e321
Reviewed-on: https://chromium-review.googlesource.com/1175852
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583663}
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/gvr_controller_delegate.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/gvr_controller_delegate.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/gvr_keyboard_delegate.h
[add] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/render_loop_factory.cc
[add] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/render_loop_factory.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_controller.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/base_compositor_delegate.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/base_compositor_delegate.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/keyboard_delegate.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/render_loop.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/render_loop.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/gl_renderer.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/gl_renderer.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/test_keyboard_delegate.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/test_keyboard_delegate.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/testapp/vr_testapp.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/ui.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/ui.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/ui_factory.cc
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/ui_factory.h
[modify] https://crrev.com/173c0a14bc75fbc768aaa22440fc4b8d366a3221/chrome/browser/vr/ui_interface.h

Comment 22 by acondor@chromium.org, Aug 17

Blockedon: 875291

Comment 23 by acondor@chromium.org, Sep 25

Status: Fixed (was: Assigned)

Comment 24 by acondor@chromium.org, Sep 25

Blockedon: -869975
►

Sign in to add a comment