New issue
Advanced search Search tips

Issue 767281 link

Starred by 1 user
Status: Fixed
Owner:
danyao@chromium.org
Closed: Sep 21
Cc:
eugene...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Tab back/forward UI button can be temporarily out of sync with underlying web state

Project Member Reported by danyao@chromium.org, Sep 21 2017 
From crbug.com/765167#c8:

eugenebut@:
ios/web does not provide good callbacks to tell embedder that forward navigation is not possible. So the enabled state of forward button may be out of sync with model for a small period of time. -[Tab goForward] sends NavigationManager::GoForward w/o prior NavigationManager::CanGoForward, so we have a crash.

... Adding better WebStateObserver callbacks would be "correct" fix and that's something that we should probably do in the future.

Comment 1 by eugene...@chromium.org, Sep 21 2017

Cc: eugene...@chromium.org
Components: UI>Browser>Navigation
Labels: -Type-Task Type-Bug
Owner: ----
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 21

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by eugene...@chromium.org, Sep 21

Owner: danyao@chromium.org
Status: Fixed (was: Untriaged)
Fixed by adding WebStateObserver::DidChangeBackForwardState
►

Sign in to add a comment