New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767279 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue angleproject:2151



Sign in to add a comment

gles2_conform_test failing on Windows Debug GPU FYI bots

Project Member Reported by jmad...@chromium.org, Sep 21 2017

Issue description

Possibly related to a CL of mine, which is in the regression range.

First failure:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/3048

Last OK:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/3047

ANGLE regression range is all my CLs, but suspecting one of:

https://chromium-review.googlesource.com/c/angle/angle/+/659224 (most likely)
https://chromium-review.googlesource.com/c/angle/angle/+/666278

The failure seems like it is happening as an error during test teardown, as the logs seem to indicate the body of the test passes successfully. Will investigate.
 
Labels: Hotlist-PixelWrangler
Summary: gles2_conform_test failing on AMD Windows 7 Debug GPU FYI bots (was: gles2_conform_test failing on AMD Windows 7 GPU FYI bots)
Status: Started (was: Assigned)
Summary: gles2_conform_test failing on Windows 7 Debug GPU FYI bots (was: gles2_conform_test failing on AMD Windows 7 Debug GPU FYI bots)
Seems to happen on any vendor, not just AMD. Looking now.
Blocking: 2151
Fix in review, it was a regression from https://chromium-review.googlesource.com/666278 (D3D11 Shader dirty bits)
Blocking: -2151 angleproject:2151
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/1f9d68437c9d3fd1bcb8fffff84fdd29d1857919

commit 1f9d68437c9d3fd1bcb8fffff84fdd29d1857919
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Sep 21 17:29:27 2017

StateManager11: Defer RenderTarget invalidation to draw.

Although this adds a boolean check (and state flag maintenance) cost
to each draw call, it makes ANGLE's internal life a lot simpler
because it doesn't have to process a framebuffer change until the
draw call. It turns out there are a few dependent checks of the
Framebuffer that aren't always easy to do. In one test, Context
destruction was triggering RenderTarget invalidation, after the
Context had already freed the Framebuffer manager.

This also fixes the problem in feature level 9_3 with framebuffer
invalidation affecting the internal dirty bit set. (Note that it
still dirties the Framebuffer for the next frame).

BUG= chromium:767279 
BUG= angleproject:2151 

Change-Id: I74d61bddf9926004a04f712a9f9eb1205d5df0e1
Reviewed-on: https://chromium-review.googlesource.com/676657
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/1f9d68437c9d3fd1bcb8fffff84fdd29d1857919/src/libANGLE/renderer/d3d/d3d11/StateManager11.h
[modify] https://crrev.com/1f9d68437c9d3fd1bcb8fffff84fdd29d1857919/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp
[modify] https://crrev.com/1f9d68437c9d3fd1bcb8fffff84fdd29d1857919/src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
[modify] https://crrev.com/1f9d68437c9d3fd1bcb8fffff84fdd29d1857919/src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp
[modify] https://crrev.com/1f9d68437c9d3fd1bcb8fffff84fdd29d1857919/src/libANGLE/renderer/d3d/d3d11/Framebuffer11.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/780f5bfdfefafacf7670573ac20c5394a55cadc6

commit 780f5bfdfefafacf7670573ac20c5394a55cadc6
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Sep 21 19:14:10 2017

Roll skia/third_party/externals/angle2/ 981f0f8f6..1f9d68437 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/981f0f8f6a34..1f9d68437c9d

$ git log 981f0f8f6..1f9d68437 --date=short --no-merges --format='%ad %ae %s'
2017-09-21 jmadill StateManager11: Defer RenderTarget invalidation to draw.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 767279 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE
TBR=fmalita@google.com

Change-Id: I6f9afe7c67a1f0d2a50605596865e8ffdeea4d20
Reviewed-on: https://skia-review.googlesource.com/49784
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/780f5bfdfefafacf7670573ac20c5394a55cadc6/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2ec8306dd6854d928eb3bf88840af0a5fdb983

commit cb2ec8306dd6854d928eb3bf88840af0a5fdb983
Author: Frank Henigman <fjhenigman@chromium.org>
Date: Thu Sep 21 19:19:25 2017

Roll ANGLE 47bf2dc..1f9d684

https://chromium.googlesource.com/angle/angle.git/+log/47bf2dc..1f9d684

BUG= chromium:767279 ,chromium:725308, chromium:765321 , chromium:655534 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I794ad67e2a1ef672855c65eef94959800cba9477
Reviewed-on: https://chromium-review.googlesource.com/677428
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503529}
[modify] https://crrev.com/cb2ec8306dd6854d928eb3bf88840af0a5fdb983/DEPS

Status: Fixed (was: Started)
Summary: gles2_conform_test failing on Windows Debug GPU FYI bots (was: gles2_conform_test failing on Windows 7 Debug GPU FYI bots)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56afb3ac0849a6de3f60787cb775257407d403cd

commit 56afb3ac0849a6de3f60787cb775257407d403cd
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Sep 21 22:48:50 2017

Roll src/third_party/skia/ 2fbf1bc8c..cfbbcbe52 (9 commits)

https://skia.googlesource.com/skia.git/+log/2fbf1bc8c96f..cfbbcbe52624

$ git log 2fbf1bc8c..cfbbcbe52 --date=short --no-merges --format='%ad %ae %s'
2017-09-21 robertphillips Temporary patch for Mac TSAN bot (with threaded Ganesh mask generation)
2017-09-21 mtklein Fix Android roll.
2017-09-21 mtklein count total non-lowp runs
2017-09-21 robertphillips Guard resource provider path creation methods against abandoned context
2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ 981f0f8f6..1f9d68437 (1 commit)
2017-09-21 mtklein Don't call GrBuffer::map() in createPatternedIndexBuffer.
2017-09-21 kjlubick [WASM] Add POC compile bot for WebAssembly
2017-09-21 mtklein no_sanitize is Clang 3.7+
2017-09-21 bsalomon Serialize rrect/oval paths as rrects rather than points and verbs.

Created with:
  roll-dep src/third_party/skia
BUG= 767279 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I959808761fe4975d87e31d7158ae0d06b1593597
Reviewed-on: https://chromium-review.googlesource.com/677480
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503591}
[modify] https://crrev.com/56afb3ac0849a6de3f60787cb775257407d403cd/DEPS

Sign in to add a comment