New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767275 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ junov@chromium.org
xidac...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 634542



Sign in to add a comment

Fix CreateImageBitmap from SVG

Project Member Reported by zakerinasab@chromium.org, Sep 21 2017 
When trying to remove the GPU readback code that was used to convert null color space SkImage to sRGB (https://chromium-review.googlesource.com/c/chromium/src/+/672023), it turned out that createImageBitmap from SVG fails when the tagging code is removed. Fix this and reactivate the SVG test in third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-createImageBitmap-{linear-rgb, p3, rec2020}.html layout tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/982d26079cf7f293d3dd05cf6783e591ca937259

commit 982d26079cf7f293d3dd05cf6783e591ca937259
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Sep 26 17:37:34 2017

Remove GPU readback in ImageBitmap when tagging SkImages as sRGB

In chromium-review.googlesource.com/670519 SkImage objects without color space
info are tagged as sRGB by drawin the image onto a sRGB canvas. This is not
needed anymore as makeColorSpace() assumes the no-color-space images as sRGB.

Bug:  754713 ,  740197 ,  767275 
Change-Id: Ic6a9461919bf49d3bf316d93ca6a5e10bc6f3d7c
Reviewed-on: https://chromium-review.googlesource.com/672023
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504414}
[modify] https://crrev.com/982d26079cf7f293d3dd05cf6783e591ca937259/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp

Comment 2 by zakerinasab@chromium.org, Sep 26 2017

Status: Fixed (was: Assigned)

Comment 3 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment