New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767274 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

HTTP status codes in protocol should be ints

Project Member Reported by allada@chromium.org, Sep 21 2017 
see: https://github.com/ChromeDevTools/devtools-protocol/issues/58

Copied:

This is true for both Response and WebSocketResponse in the Network domain, their status properties are of type number instead of integer. Could they be changed to integer (as per HTTP spec) or is there something that relies on them being numbers?

The reason I'm asking is that I maintain a Go library for the protocol (cdp) where typed code is generated from the protocol definition and the distinction is useful. In mafredri/cdp#27 a user asked why this wasn't an int, reasonably so.

Is there anything I can do to help get this changed?
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/795fd9f8814ba288c2cb6ad679f6d6cdd3e62a37

commit 795fd9f8814ba288c2cb6ad679f6d6cdd3e62a37
Author: Nathan Bruer <allada@chromium.org>
Date: Tue Sep 26 01:54:34 2017

[Devtools] Change HTTP status codes in protocol to be ints

Per spec protocol should forward the response status code as an int instead
of numbers.

See: https://github.com/ChromeDevTools/devtools-protocol/issues/58

R=pfeldman
BUG= 767274 

Change-Id: I450278a2889352d077373e7c1d2ea0d80367b7cd
Reviewed-on: https://chromium-review.googlesource.com/676504
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504258}
[modify] https://crrev.com/795fd9f8814ba288c2cb6ad679f6d6cdd3e62a37/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/795fd9f8814ba288c2cb6ad679f6d6cdd3e62a37/third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json
[modify] https://crrev.com/795fd9f8814ba288c2cb6ad679f6d6cdd3e62a37/third_party/WebKit/Source/core/inspector/browser_protocol.json

Comment 2 by allada@chromium.org, Sep 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment