We can ignore testing variance on the Origin header since the requesting origin can't have changed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1bbdf74ef73fe5d1e3554dbfe1eae8589fb1add

commit e1bbdf74ef73fe5d1e3554dbfe1eae8589fb1add
Author: Michael Nordman <michaeln@google.com>
Date: Fri Sep 22 19:50:59 2017

AppCache: Reuse resources with Vary headers only including Origin and/or Accept-Encoding

Bug:  767267 
Change-Id: I3ea9a221012fa927cb4e78789a06b090ce4e1e78
Reviewed-on: https://chromium-review.googlesource.com/676529
Commit-Queue: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503826}
[modify] https://crrev.com/e1bbdf74ef73fe5d1e3554dbfe1eae8589fb1add/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/e1bbdf74ef73fe5d1e3554dbfe1eae8589fb1add/content/browser/appcache/appcache_update_job_unittest.cc

fixed but leaving open, waiting for feedback next week and may be requesting a merge

The docs team has requested to merge this in m62, they've verified that the fix works for them on canary.

This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Thanks for the fix and requesting a merge. Can you please quickly summarize what's the change (on a high-level), and why this needs to be merged to M62 (seems like it's been around since 2016) and what are the downsides if we wait until M63?

Discussed over email, and approving this merge to M62. Branch:3202. 

great, thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411624892f977f0d18fa35b1a8f3531674d3eab9

commit 411624892f977f0d18fa35b1a8f3531674d3eab9
Author: Michael Nordman <michaeln@google.com>
Date: Tue Sep 26 21:29:41 2017

AppCache: Reuse resources with Vary headers only including Origin and/or Accept-Encoding

TBR=michaeln@google.com

(cherry picked from commit e1bbdf74ef73fe5d1e3554dbfe1eae8589fb1add)

Bug:  767267 
Change-Id: I3ea9a221012fa927cb4e78789a06b090ce4e1e78
Reviewed-on: https://chromium-review.googlesource.com/676529
Commit-Queue: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503826}
Reviewed-on: https://chromium-review.googlesource.com/685364
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#458}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/411624892f977f0d18fa35b1a8f3531674d3eab9/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/411624892f977f0d18fa35b1a8f3531674d3eab9/content/browser/appcache/appcache_update_job_unittest.cc

merged to 62, requesting merge to 63

63 hasn't branched yet - no need to merge?

This bug requires manual review: We don't branch M63 until 2017-10-12.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

doh, thank you :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6062ffc539155be9ddff22b79349b12e45ce71b4

commit 6062ffc539155be9ddff22b79349b12e45ce71b4
Author: Michael Nordman <michaeln@google.com>
Date: Wed Sep 27 00:32:31 2017

Revert "AppCache: Reuse resources with Vary headers only including Origin and/or Accept-Encoding"

This reverts commit 411624892f977f0d18fa35b1a8f3531674d3eab9.

TBR=michaeln@google.com

Bug:  767267 
Change-Id: If4c3ef2f648df58627faa646afe5faa026dbcf9b
Reviewed-on: https://chromium-review.googlesource.com/686000
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#461}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6062ffc539155be9ddff22b79349b12e45ce71b4/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/6062ffc539155be9ddff22b79349b12e45ce71b4/content/browser/appcache/appcache_update_job_unittest.cc

i botched the release build and had to revert it

../../content/browser/appcache/appcache_update_job_unittest.cc(1584): error C2664: 'void content::AppCacheResponseWriter::WriteInfo(content::HttpResponseInfoIOBuffer *,const net::CompletionCallback &)': cannot convert argument 2 from 'base::OnceCallback<R (int)>' to 'const net::CompletionCallback &'
        with
        [
            R=void
        ]
../../content/browser/appcache/appcache_update_job_unittest.cc(1584): note: Reason: cannot convert from 'base::OnceCallback<R (int)>' to 'const net::CompletionCallback'
        with
        [
            R=void
        ]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9871a22b6fa08657c1b48d59b58d34748fc40080

commit 9871a22b6fa08657c1b48d59b58d34748fc40080
Author: Michael Nordman <michaeln@google.com>
Date: Wed Sep 27 01:39:04 2017

Reland "AppCache: Reuse resources with Vary headers only including Origin and/or Accept-Encoding"

This is a reland of 411624892f977f0d18fa35b1a8f3531674d3eab9
Original change's description:
> AppCache: Reuse resources with Vary headers only including Origin and/or Accept-Encoding
> 
> TBR=michaeln@google.com
> 
> (cherry picked from commit e1bbdf74ef73fe5d1e3554dbfe1eae8589fb1add)
> 
> Bug:  767267 
> Change-Id: I3ea9a221012fa927cb4e78789a06b090ce4e1e78
> Reviewed-on: https://chromium-review.googlesource.com/676529
> Commit-Queue: Michael Nordman <michaeln@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#503826}
> Reviewed-on: https://chromium-review.googlesource.com/685364
> Reviewed-by: Michael Nordman <michaeln@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3202@{#458}
> Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}

Bug:  767267 
Change-Id: Iafb291fd31dfb73f414643df9b54c7b86dee3bae
Reviewed-on: https://chromium-review.googlesource.com/685901
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#462}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/9871a22b6fa08657c1b48d59b58d34748fc40080/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/9871a22b6fa08657c1b48d59b58d34748fc40080/content/browser/appcache/appcache_update_job_unittest.cc

really fixed now, the reland stuck