rebaseline-cl: When rebaselining a test with text diff but no image diff, only txt baseline should be downloaded |
||||
Issue descriptionWhen a test fails with a text failure but not an image failure, only the text baselines should be updated. The current behavior appears to be that the png is also downloaded. The png can have differences in metadata even if the screenshot matches, which can cause problems. Possible relevant section of the rebaseline code: _suffixes_for_actual_failures https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py?l=458
,
Dec 15 2017
robertma@, can this ever be an issue for wpt-import?
,
Dec 15 2017
For WPT, there are no pixel tests, so there are never any png baselines to download, so I believe this issue wouldn't affect wpt-import.
,
Dec 17
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Sep 25 2017