New issue
Advanced search Search tips

Issue 767257 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Open settings page in a windowed app

Project Member Reported by lgcheng@google.com, Sep 21 2017

Issue description

Open settings page in windowed app when user clicks on settings link in ARC optin page.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66866dd522fc1a483f921b58946bd4d4cd56d2f7

commit 66866dd522fc1a483f921b58946bd4d4cd56d2f7
Author: lgcheng <lgcheng@google.com>
Date: Thu Sep 21 02:30:44 2017

Open windowed settings page rather than in browser.

Open a windowed settings page rather than open chrome://settings page in
browers when user clicks setting link.

Bug:  767257 
Test: Maunal
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I349ada199f2263fdab0004975be9375c3fbedb67
Reviewed-on: https://chromium-review.googlesource.com/676443
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#503319}
[modify] https://crrev.com/66866dd522fc1a483f921b58946bd4d4cd56d2f7/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/66866dd522fc1a483f921b58946bd4d4cd56d2f7/chrome/browser/resources/chromeos/arc_support/background.js

Comment 2 by lgcheng@google.com, Sep 21 2017

Labels: Merge-Request-61 Merge-Request-62
TPM PTAL here. Let me know if it's ok to merge, or target to right milestone. 

Thanks!
Labels: -M-61 -Merge-Request-61 -Merge-Request-62 Merge-Approved-62 Merge-Rejected-61
Approved for 62, default deny for 61, if this is critical please let us know.

Comment 4 by lgcheng@google.com, Sep 22 2017

Cc: bhthompson@google.com
Labels: -Merge-Rejected-61 Merge-Request-61
Hi Bernie, 

Confirmed with Hiro, we do want this UI change In M61, Can you take a second look?
Labels: -Merge-Request-61 Merge-Approved-61
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 22 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f9d6f9cd6f816afca6a2facfc71d790e67f961

commit 53f9d6f9cd6f816afca6a2facfc71d790e67f961
Author: lgcheng <lgcheng@google.com>
Date: Fri Sep 22 18:08:21 2017

Open windowed settings page rather than in browser.

Open a windowed settings page rather than open chrome://settings page in
browers when user clicks setting link.

TBR=xiyuan@chromium.org

Bug:  767257 
Test: Maunal
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I349ada199f2263fdab0004975be9375c3fbedb67
Reviewed-on: https://chromium-review.googlesource.com/676443
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#503319}(cherry picked from commit 66866dd522fc1a483f921b58946bd4d4cd56d2f7)
Reviewed-on: https://chromium-review.googlesource.com/678124
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3202@{#398}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/53f9d6f9cd6f816afca6a2facfc71d790e67f961/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/53f9d6f9cd6f816afca6a2facfc71d790e67f961/chrome/browser/resources/chromeos/arc_support/background.js

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e2f8199697408099ba90e0b8aad873a0aac79d6

commit 5e2f8199697408099ba90e0b8aad873a0aac79d6
Author: lgcheng <lgcheng@google.com>
Date: Fri Sep 22 18:14:01 2017

Open windowed settings page rather than in browser.

Open a windowed settings page rather than open chrome://settings page in
browers when user clicks setting link.

TBR=xiyuan@chromium.org

Bug:  767257 
Test: Maunal
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I349ada199f2263fdab0004975be9375c3fbedb67
Reviewed-on: https://chromium-review.googlesource.com/676443
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#503319}(cherry picked from commit 66866dd522fc1a483f921b58946bd4d4cd56d2f7)
Reviewed-on: https://chromium-review.googlesource.com/679094
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3163@{#1263}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5e2f8199697408099ba90e0b8aad873a0aac79d6/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/5e2f8199697408099ba90e0b8aad873a0aac79d6/chrome/browser/resources/chromeos/arc_support/background.js

Comment 8 by lgcheng@google.com, Sep 22 2017

Status: Fixed (was: Started)

Sign in to add a comment