New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767240 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue angleproject:1951



Sign in to add a comment

ShaderStorageBufferReadWrite failing on Linux Intel

Project Member Reported by briander...@chromium.org, Sep 20 2017

Issue description

Cc: jmad...@chromium.org
Jamie, do you think this is due to the angle roll?

Labels: Hotlist-PixelWrangler

Comment 3 by kbr@chromium.org, Sep 20 2017

Cc: geoffl...@chromium.org jiajia....@intel.com
Labels: -Pri-3 Pri-2
These bots need to stay green even though they're on the FYI waterfall. Upgrading to P2.

This is certainly a new test that's failing because the affected machine isn't on the try servers. The Intel folks should triage it, and we should add a suppression in the meantime.

BTW Brian, ANGLE rolls don't apply to the GPU.FYI bots, since they are hard-coded to use ToT ANGLE. To find the regression range, look at "parent_got_angle_revision" for the ANGLE commit hashes of the first failing/last known good.
Blocking: angleproject:1951
Owner: jiajia....@intel.com
Status: Assigned (was: Untriaged)
Will land a suppression, but jiajia, could you investigate?
Yes, I will investigate it. Please suppress it. Thanks.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/a08d410d1b36aa31f700ed7da5ed90cf6a5c0969

commit a08d410d1b36aa31f700ed7da5ed90cf6a5c0969
Author: Qin Jiajia <jiajia.qin@intel.com>
Date: Fri Jan 19 12:08:54 2018

Fixed ssbo end2end tests failure

The array stride is implementation-dependent if the storage layout is
not standard layout. So this change will use std140 as the layout to
fix the bug.

BUG= 767240 ,angleproject:2255

Change-Id: I21de52ebad6d27783eeade63d6fac81c0842085d
Reviewed-on: https://chromium-review.googlesource.com/861313
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/a08d410d1b36aa31f700ed7da5ed90cf6a5c0969/src/tests/gl_tests/ShaderStorageBufferTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc5b27d1057699417d7dfbe3ff15831865834b65

commit bc5b27d1057699417d7dfbe3ff15831865834b65
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Jan 19 14:00:36 2018

Roll src/third_party/angle/ fa8869752..a08d410d1 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/fa8869752a63..a08d410d1b36

$ git log fa8869752..a08d410d1 --date=short --no-merges --format='%ad %ae %s'
2018-01-11 jiajia.qin Fixed ssbo end2end tests failure
2018-01-16 oetuaho Make TVariable type immutable

Created with:
  roll-dep src/third_party/angle
BUG= 767240 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I66c4bafcc75160d9d13357b899c892a83b06b930
Reviewed-on: https://chromium-review.googlesource.com/875906
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530504}
[modify] https://crrev.com/bc5b27d1057699417d7dfbe3ff15831865834b65/DEPS

Status: Fixed (was: Assigned)
 

Sign in to add a comment