New issue
Advanced search Search tips

Issue 767226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 589943



Sign in to add a comment

[Mac] MD downloads highlight rect looks off-center

Project Member Reported by shrike@chromium.org, Sep 20 2017

Issue description

Chrome Version: 63.0.3220.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Download an item
(2) Mouse over the item


What is the expected result?
The highlight rect should be centered horizontally within the button

What happens instead?
The highlight looks like it's too close to the right side of the button.
 
Screen Shot 2017-09-20 at 3.33.57 PM.png
7.7 KB View Download

Comment 1 by sdy@chromium.org, Oct 6 2017

Blocking: 589943

Comment 2 by sdy@chromium.org, Oct 6 2017

Labels: -M-63 M-64

Comment 3 by sdy@chromium.org, Oct 13 2017

Cc: sdy@chromium.org
Owner: bettes@chromium.org
This is part of the design. bettes@, thoughts?

Comment 4 by bettes@chromium.org, Oct 18 2017

Yeah, actually I agree with shrike on this one. Can you increase the right-handed padding to match the left, please? 

Comment 5 by bettes@chromium.org, Oct 18 2017

Cc: -sdy@chromium.org bettes@chromium.org
Owner: sdy@chromium.org

Comment 6 by sdy@chromium.org, Nov 4 2017

Status: Started (was: Assigned)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/753758
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac1a675f366123043e11d737ce1661cbbff4af93

commit ac1a675f366123043e11d737ce1661cbbff4af93
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Nov 06 14:13:05 2017

Balance MD download shelf button padding.

Bug:  767226 
Change-Id: I66c219d6a3a7aa7c0a94663dbad0b0c221fdbb3f
Reviewed-on: https://chromium-review.googlesource.com/753758
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514122}
[modify] https://crrev.com/ac1a675f366123043e11d737ce1661cbbff4af93/chrome/browser/ui/cocoa/download/md_download_item_view.mm

Comment 8 by sdy@chromium.org, Nov 6 2017

Status: Fixed (was: Started)

Sign in to add a comment