New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 589943



Sign in to add a comment

[Mac] MD downloads problem with shelf overflow in RTL

Project Member Reported by shrike@chromium.org, Sep 20 2017

Issue description

Chrome Version: 63.0.3220.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Launch Chrome in RTL (  -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES --force-ui-direction=rtl --enable-features=MacRTL )
(2) Download more items than will fit in the download tray

What is the expected result?
The leftmost item fades out as the remaining items slide to the left.

What happens instead?
All of the items slide to the left, leaving the leftmost item beneath the Show All area.
 
DownloadOverflow.mov
111 KB Download

Comment 1 by sdy@chromium.org, Oct 6 2017

Blocking: 589943

Comment 2 by sdy@chromium.org, Oct 6 2017

Labels: -M-63 M-64

Comment 3 by sdy@chromium.org, Oct 13 2017

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/720116
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/795953812c14480c171b7dfade1fc8acb33eaa78

commit 795953812c14480c171b7dfade1fc8acb33eaa78
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Oct 16 15:31:14 2017

Fix overflowing downloads not hiding in RTL.

Bug:  767225 
Change-Id: I868ef5359287220d928249bf34d1b62f8a83e8d5
Reviewed-on: https://chromium-review.googlesource.com/720116
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509052}
[modify] https://crrev.com/795953812c14480c171b7dfade1fc8acb33eaa78/chrome/browser/ui/cocoa/download/download_item_controller.mm

Comment 5 by sdy@chromium.org, Oct 16 2017

Status: Fixed (was: Started)

Comment 6 by hdodda@chromium.org, Oct 17 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on mac os 10.12.6 using chrome M64 #64.0.3242.0 and observed that issue is still reproduced.

An extra space is seen to the left side of the new downloaded file.

Attached screenshot for reference.

@Sidney San Martín-- Could you please check attached screenshot and let us know if this is expected.

Thanks!
767225.png
14.2 KB View Download

Comment 7 by sdy@chromium.org, Oct 17 2017

hdodda@: This only applies to the MD download shelf, sorry. You'll need to run with `--enable-features=MacMDDownloadShelf` or turn it on in about:flags.

Sign in to add a comment