[Mac] MD downloads button content off-center in RTL |
||||
Issue descriptionChrome Version: 63.0.3220.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Launch Chrome in RTL ( -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES --force-ui-direction=rtl --enable-features=MacRTL ) (2) Download an item (3) Mouse over the download button What is the expected result? Highlight should be centered within the button, and the menu dots should be comfortably positioned at the button's left edge. What happens instead? The dots are too close to the left edge and the highlight rect is off-center.
,
Oct 6 2017
,
Oct 13 2017
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d70100c8cdebeab7a960e4ea939ab28878624d2 commit 8d70100c8cdebeab7a960e4ea939ab28878624d2 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Oct 16 15:36:57 2017 Fix download button content alignment in RTL. Bug: 767224 Change-Id: I33c9342330c9a41d041258ff57d024e7c1680519 Reviewed-on: https://chromium-review.googlesource.com/720117 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509057} [modify] https://crrev.com/8d70100c8cdebeab7a960e4ea939ab28878624d2/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Oct 16 2017
,
Oct 17 2017
Tested the issue on Mac OS 10.12.6 using chrome M64 #64.0.3242.0 and followed the below steps: 1. Launched chrome with the following flags from command prompt : -NSForceRightToLeftWritingDirection -AppleTextDirection --force-ui-direction=rtl --enable-features=MacRTL 2.Downloaded an item and hovered on it and couldn't observe any three dot menu .. Attached screencast for reference. @sdy-- Could you please check attached screencast and confirm us if we have missed any steps in verifying the issue . Thanks!
,
Oct 17 2017
hdodda@: This only applies to the MD download shelf, sorry. You'll need to run with `--enable-features=MacMDDownloadShelf` or turn it on in about:flags. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sdy@chromium.org
, Oct 6 2017