Remove (beta) string to playstore |
|||||||||
Issue descriptionBased on request in https://b.corp.google.com/issues/65853777 Remove beta string of IDS_SETTINGS_ANDROID_APPS_TITLE : settings page label IDS_ARC_PLAYSTORE_ICON_TITLE_BETA : app launcher icon IDS_ARC_MANAGED_PROVISION_NOTIFICATION_TITLE : notification for silent auth in managed cases
,
Sep 20 2017
,
Sep 20 2017
Bernie@ would you help approve the merge request for string change?
,
Sep 20 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 20 2017
We can merge this but we need to verify we are ok without doing any translations.
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/680c0735a12108841ee0b5a762e9ae41b88b2b4d commit 680c0735a12108841ee0b5a762e9ae41b88b2b4d Author: lgcheng <lgcheng@google.com> Date: Wed Sep 20 23:59:46 2017 Remove beta string. Remove beta string of Play Store and Google Play Store. TBR=dpapad@chromium.org, cpu@chromium.org Bug: 767212 Test: manul. Change-Id: I99fbab7d985c4658da12b833867cdfd524438074 Reviewed-on: https://chromium-review.googlesource.com/676101 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#503286} [modify] https://crrev.com/680c0735a12108841ee0b5a762e9ae41b88b2b4d/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/680c0735a12108841ee0b5a762e9ae41b88b2b4d/chrome/app/settings_strings.grdp
,
Sep 21 2017
Approved for 61 and 62.
,
Sep 21 2017
+govind for FYI, for 61 in this case we can get by with just the English version.
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e20ad53543c1b6d2b40b66527e77827d1c69b44 commit 3e20ad53543c1b6d2b40b66527e77827d1c69b44 Author: lgcheng <lgcheng@google.com> Date: Thu Sep 21 17:36:00 2017 Remove beta string. Remove beta string of Play Store and Google Play Store. TBR=dpapad@chromium.org, cpu@chromium.org Bug: 767212 Test: manul. Change-Id: I99fbab7d985c4658da12b833867cdfd524438074 Reviewed-on: https://chromium-review.googlesource.com/676101 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by: Long Cheng <lgcheng@google.com> Cr-Original-Commit-Position: refs/heads/master@{#503286}(cherry picked from commit 680c0735a12108841ee0b5a762e9ae41b88b2b4d) Reviewed-on: https://chromium-review.googlesource.com/676952 Cr-Commit-Position: refs/branch-heads/3202@{#378} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/3e20ad53543c1b6d2b40b66527e77827d1c69b44/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/3e20ad53543c1b6d2b40b66527e77827d1c69b44/chrome/app/settings_strings.grdp
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0288bcea9a9bc74a6d149b445f39ce547f804c0 commit d0288bcea9a9bc74a6d149b445f39ce547f804c0 Author: lgcheng <lgcheng@google.com> Date: Thu Sep 21 17:38:18 2017 Remove beta string. Remove beta string of Play Store and Google Play Store. TBR=dpapad@chromium.org, cpu@chromium.org Bug: 767212 Test: manul. Change-Id: I99fbab7d985c4658da12b833867cdfd524438074 Reviewed-on: https://chromium-review.googlesource.com/676101 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by: Long Cheng <lgcheng@google.com> Cr-Original-Commit-Position: refs/heads/master@{#503286}(cherry picked from commit 680c0735a12108841ee0b5a762e9ae41b88b2b4d) Reviewed-on: https://chromium-review.googlesource.com/677072 Cr-Commit-Position: refs/branch-heads/3163@{#1254} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d0288bcea9a9bc74a6d149b445f39ce547f804c0/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/d0288bcea9a9bc74a6d149b445f39ce547f804c0/chrome/app/settings_strings.grdp
,
Sep 21 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by lgcheng@google.com
, Sep 20 2017