New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767202 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 798565



Sign in to add a comment

Weird Flicker in In Product Help New Tab Button Animation in tools menu.

Project Member Reported by gch...@chromium.org, Sep 20 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): Trunk
iOS Version: 10
Device: iPhone 6s

Steps to reproduce: 
Enable promo demo mode.
Get New Incognito Tab bubble to appear.
Open Tools Menu.

Observed behavior: 
New Incognito button flashes several times. The last flash has a weird flicker.
Expected behavior: 
There should be no flicker.


 

Comment 1 by gch...@chromium.org, Sep 20 2017

Summary: Weird Flicker in In Product Help New Tab Button Animation in tools menu. (was: Issue Summary)

Comment 2 by gch...@chromium.org, Sep 20 2017

Labels: Proj-InProductHelp

Comment 3 by gch...@chromium.org, Sep 20 2017

Labels: -Restrict-View-Google

Comment 4 by ghendel@google.com, Oct 20 2017

Labels: -Pri-2 Pri-1

Comment 5 by gch...@chromium.org, Dec 11 2017

Cc: ghendel@chromium.org
Labels: Incognito-Promo-Only
Should remove from hotlists since Incognito only. 
Done
Blocking: 798565
This seems to be only reproducing on device.
Problem seems to be that when the second animation is terminating, there is a gap between the completion handler and the end of the autoreversed animation.
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81dc3d48490a10773cec0a0b64081608a7614f2a

commit 81dc3d48490a10773cec0a0b64081608a7614f2a
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Wed Jan 03 23:32:24 2018

Fix flickering tools menu item animation.

The tools menu item animation that is triggered after the dismissal of
the Incognito In Product Help Bubble flickers at the end. This happens
because there is a gap between the end of the autoreversed animation
(where the item has a highlighted background) and the completion handler
(which sets the item to a white background). The fix is to use a
CABasicAnimation instead of |animateWithDuration|.

Bug:  767202 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79d57ecf7e77281e9d6d112a66e8e7d20efcccef
Reviewed-on: https://chromium-review.googlesource.com/849176
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526861}
[modify] https://crrev.com/81dc3d48490a10773cec0a0b64081608a7614f2a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment