New issue
Advanced search Search tips

Issue 767194 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Sep 2017
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix crash in RequestSenderTest due to interceptors not being cleaned up between tests.

Project Member Reported by sorin@chromium.org, Sep 20 2017 
There is a global, shared instance of URLRequestFilter. There must be only one interceptor for a given {protocol, host} pair. Therefore, cleaning up interceptors between tests is critical for the success of the tests.

Interceptors are registered and unregistered on the IO thread, which must pump messages for the calls to succeed.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f805c2264efd4b9796cf692fa38742fd71ab78eb

commit f805c2264efd4b9796cf692fa38742fd71ab78eb
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed Sep 20 22:36:21 2017

Fix crash in RequestSenderTest due to interceptors not being cleaned up between tests.

Bug:  767194 
Change-Id: If7d4b8a448b2d5b0bbf9ee0b9e36166b5b69e30c
Reviewed-on: https://chromium-review.googlesource.com/676196
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503272}
[modify] https://crrev.com/f805c2264efd4b9796cf692fa38742fd71ab78eb/components/update_client/request_sender_unittest.cc

Comment 2 by sorin@chromium.org, Sep 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment