New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767192 link

Starred by 1 user
Status: Fixed
Owner:
█ rkaplow@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UKM should not be affected by MetricsReporting Feature

Project Member Reported by rkaplow@chromium.org, Sep 20 2017 
MetricsReporting feature was setup to sample UMA/Rappor clients as they existed before the enabled-bit change.
Since UKM has only existed since then (removing bias need) and has the UKM Feature for sampling (removing the scaling need), it shouldn't also be controlled by this scaling feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c998692a2d9882fae601068eef798b0b03297306

commit c998692a2d9882fae601068eef798b0b03297306
Author: Robert Kaplow <rkaplow@chromium.org>
Date: Fri Sep 29 02:05:49 2017

Make UKM unaffected by the state of the MetricsReporting Feature.



Bug:  767192 
Change-Id: Ibea39c5a94c36d8c7c67672ee7fc380f50fa7acb
Reviewed-on: https://chromium-review.googlesource.com/676193
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505253}
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/chrome/browser/metrics/chrome_metrics_services_manager_client.h
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/components/metrics/metrics_reporting_default_state.cc
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/components/metrics/metrics_reporting_default_state.h
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/components/metrics_services_manager/metrics_services_manager.cc
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/components/metrics_services_manager/metrics_services_manager.h
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/components/metrics_services_manager/metrics_services_manager_client.h
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h
[modify] https://crrev.com/c998692a2d9882fae601068eef798b0b03297306/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

Comment 2 by rkaplow@chromium.org, May 3 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment