New issue
Advanced search Search tips

Issue 767177 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Trigger Pak Extraction on Package Update

Project Member Reported by agrieve@chromium.org, Sep 20 2017

Issue description

Extracting .pak files after Chrome is updated slows down start-up.

We already have an ACTION_MY_PACKAGE_REPLACED Receiver (https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java).

We should tell it to extract .pak files.
 
Cc: yfried...@chromium.org agrieve@chromium.org
 Issue 766726  has been merged into this issue.
When I was trying to trigger the ACTION_MY_PACKAGE_REPLACED broadcast (via adb install -r ChromePublic.apk) I noticed that ResourceExtractor already runs:

org.chromium.base.ResourceExtractor.startExtractingResources(ResourceExtractor.java:227)
org.chromium.chrome.browser.init.ChromeBrowserInitializer.postInflationStartup(ChromeBrowserInitializer.java:237)
org.chromium.chrome.browser.init.ChromeBrowserInitializer.handlePreNativeStartup(ChromeBrowserInitializer.java:167)
org.chromium.chrome.browser.init.ChromeBrowserInitializer.handleSynchronousStartupInternal(ChromeBrowserInitializer.java:147)
org.chromium.chrome.browser.init.ChromeBrowserInitializer.handleSynchronousStartup(ChromeBrowserInitializer.java:127)
org.chromium.chrome.browser.ChromeBackgroundService.launchBrowser(ChromeBackgroundService.java:108)
org.chromium.chrome.browser.ChromeBackgroundService.handleSnippetsOnBrowserUpgraded(ChromeBackgroundService.java:125)
org.chromium.chrome.browser.ChromeBackgroundService.onInitializeTasks(ChromeBackgroundService.java:139)
com.google.android.gms.gcm.GcmTaskService.onStartCommand(Unknown Source)

This was on KitKat - not sure if this runs on other Android versions yet. I also don't really see exactly why this runs or what initiates it, but if it happens consistently than it might not be worth it to add another task for ACTION_MY_PACKAGE_REPLACED?
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 21

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug Performance-Startup Type-Task
Owner: agrieve@chromium.org
Status: Assigned (was: Untriaged)
@agrieve, Still relevant?
Status: WontFix (was: Assigned)
Nope. I think #2 shows this is already the case.

Sign in to add a comment